Bug 225457 - ports-mgmt/poudriere: Add DIALOG4PORTS option
Summary: ports-mgmt/poudriere: Add DIALOG4PORTS option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-25 21:11 UTC by Yasuhiro Kimura
Modified: 2018-06-01 18:34 UTC (History)
2 users (show)

See Also:
yasu: maintainer-feedback? (bdrewery)

Attachments
patch file (1.42 KB, patch)
2018-01-25 21:11 UTC, Yasuhiro Kimura 		no flags Details | Diff
updated patch file (4.05 KB, patch)
2018-01-26 05:30 UTC, Yasuhiro Kimura 		no flags Details | Diff
updated patch file (1.06 KB, patch)
2018-04-29 18:29 UTC, Yasuhiro Kimura 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2018-01-25 21:11:05 UTC 
Created attachment 190066 [details]
patch file

* Add ports-mgmt/dialog4ports to RUN_DEPENDS because 'options' command uses it to edit options setting.
* Bump PORTREVISON because of dependency change.
Comment 1 Bryan Drewery freebsd_committer freebsd_triage 2018-01-25 23:07:26 UTC 
It should really be an optional dependency since not everyone uses 'options'. A lot just use make.conf overrides. I don't mind making it default for package building though.
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2018-01-26 05:30:29 UTC 
Created attachment 190076 [details]
updated patch file

(In reply to Bryan Drewery from comment #1)

OK, I updated patch so dependency on dialog4ports is optional. 

And while I am here installation of bundled rm command is removed because no supported FreeBSD version requires it any more.
Comment 3 Bryan Drewery freebsd_committer freebsd_triage 2018-01-29 19:20:25 UTC 
(In reply to Yasuhiro KIMURA from comment #2)
> Created attachment 190076 [details]
> updated patch file
> 
> (In reply to Bryan Drewery from comment #1)
> 
> OK, I updated patch so dependency on dialog4ports is optional. 
> 
> And while I am here installation of bundled rm command is removed because no
> supported FreeBSD version requires it any more.

Did you read the comment? Please don't remove it.

You'll need to rebase your patch now since I won't commit your 'rm' removal and I need to update poudriere-devel.
Comment 4 Bryan Drewery freebsd_committer freebsd_triage 2018-02-02 18:05:28 UTC 
-devel updated. Will update main once I do a release.
Comment 5 Yasuhiro Kimura freebsd_committer freebsd_triage 2018-04-29 18:29:44 UTC 
Created attachment 192916 [details]
updated patch file

Update patch to make it fit to latest ports treee.
So plase commit attached patch instead of previous ones.
Comment 6 Bryan Drewery freebsd_committer freebsd_triage 2018-05-03 23:10:33 UTC 
Committed, thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-05-03 23:11:07 UTC 
A commit references this bug:

Author: bdrewery
Date: Thu May  3 23:10:12 UTC 2018
New revision: 468995
URL: https://svnweb.freebsd.org/changeset/ports/468995

Log:
  - Add DIALOG4PORTS option (default on) to install it for 'options' command [1].
  - Add CERTS option (default on) to allow disabling cert dependencies.
  - Reword QEMU_DESC to match poudriere-devel.
  - Only install ZSH files if the option is enabled.

  PR:		225457 [1]
  Submitted by:	Yasuhiro KIMURA <yasu@utahime.org> [1] (based on)

Changes:
  head/ports-mgmt/poudriere/Makefile
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-06-01 18:34:02 UTC 
A commit references this bug:

Author: bdrewery
Date: Fri Jun  1 18:33:39 UTC 2018
New revision: 471281
URL: https://svnweb.freebsd.org/changeset/ports/471281

Log:
  MFH: r468995 r471280

  - Add DIALOG4PORTS option (default on) to install it for 'options' command [1].
  - Add CERTS option (default on) to allow disabling cert dependencies.
  - Reword QEMU_DESC to match poudriere-devel.
  - Only install ZSH files if the option is enabled.

  PR:		225457 [1]
  Submitted by:	Yasuhiro KIMURA <yasu@utahime.org> [1] (based on)

  - Update to 3.2.7

  Very minor maintenance release.
  Changes: https://github.com/freebsd/poudriere/wiki/release_notes_327

  Approved by:	portmgr (implicit)

Changes:
_U  branches/2018Q2/
  branches/2018Q2/ports-mgmt/poudriere/Makefile
  branches/2018Q2/ports-mgmt/poudriere/distinfo