Created attachment 190328 [details] Improve description of OPENJPEG option The OPENJPEG option is used for JPEG 2000 support via OpenJPEG. The alternative support is via JASPER. Most ports use either one or the other. Some may support both. This patch changes the default description of OPENJPEG option to match, which also better explains what OPENJPEG is really for.
Reassigned to freebsd-ports-bugs. Any committer is welcome to commit to bsd.options.desc.mk.
CC maintainer of graphics/openjpeg for opinion. A question has been raised on IRC whether OpenJPEG is only about JPEG2000 as I suggest it is, or has a broader scope and thus should NOT be renamed as suggested here.
Could you provide the irc log? The new description is OK to me.
(In reply to Sunpoet Po-Chuan Hsieh from comment #3) Unfortunately I don't have the logs. But I'm CC'ing koobs@, who raised the objection. Namely, I asked him for opinion on clearing up the OPTIONS database wrt usage of OpenJPEG and Jasper, for JPEG2000 support, as I wanted to submit such a patch, and this one here is just a first step. Two ports, py-pillow and ImageMagick (6, 7) use JPEG2000 named option but really they link against libopenjpeg for those options. All other ports use either OPENJPEG option, or JASPER. So right now there are three OPTIONs for JPEG2000 support, two of which are used for OpenJPEG: OPENJPEG and JPEG2000 for those two ports, which I wanted to consolidate as OPENJPEG. And really, ports either use OpenJPEG, or Jasper, some may have support for both. Also CC-ing maintainer of ImageMagick.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=411e1069b3de6cf3bb9ed82c2b00fde8c5c52b89 commit 411e1069b3de6cf3bb9ed82c2b00fde8c5c52b89 Author: VK <vlad-fbsd@acheronmedia.com> AuthorDate: 2024-12-28 20:48:33 +0000 Commit: Gleb Popov <arrowd@FreeBSD.org> CommitDate: 2024-12-28 20:48:33 +0000 Mk/bsd.options.desc.mk: Improve description of OPENJPEG PR: 225674 Approved by: sunpoet (with graphics/openjpeg maintainer's hat) Mk/bsd.options.desc.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)