Bug 225786 - graphics/gmt: Update to 4.5.17 and take maintainership
Summary: graphics/gmt: Update to 4.5.17 and take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2018-02-09 06:43 UTC by Loïc Bartoletti
Modified: 2018-02-22 19:04 UTC (History)
1 user (show)

See Also:
lbartoletti: maintainer-feedback+

Attachments
gmt 4.5.17 (1.27 KB, patch)
2018-02-09 06:43 UTC, Loïc Bartoletti 		lbartoletti: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Loïc Bartoletti freebsd_committer freebsd_triage 2018-02-09 06:43:44 UTC 
Created attachment 190454 [details]
gmt 4.5.17

Minor changes
Take maintainership

Poudriere 10/11 i386/amd64 OK
Porlint OK
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-09 21:30:19 UTC 
Thank you for your patch.

In the future please try to create patches/shars from /usr/ports. It is more convenient this way.

Thank you!
Yuri
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-09 21:40:44 UTC 
I enabled all options, and got this error:
> gmake[4]: mkoctfile: Command not found

Another problem is that it builds everything with debug flags:
> cc -pipe -fno-omit-frame-pointer  -g -fstack-protector -fno-strict-aliasing -g -Wall  -fPIC -fno-strict-aliasing -std=c99 -I/usr/ports/graphics/gmt/work/gmt-4.5.17/src -I../mgg -I/usr/local/include -I/usr/local/include  -fno-omit-frame-pointer -DUSE_GDAL -DDEBUG  -c -o x_remove.o x_remove.c

It needs to respect CFLAGS.

Another problem is that it uses has USES=autoreconf:build while 'configure' file is present. 'configure' should be preferred when present, unless it fails for some reason. In such case there should be a comment explaining this.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-22 19:03:44 UTC 
Committed.
Thank you for taking maintainership!
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-02-22 19:04:14 UTC 
A commit references this bug:

Author: yuri
Date: Thu Feb 22 19:03:40 UTC 2018
New revision: 462620
URL: https://svnweb.freebsd.org/changeset/ports/462620

Log:
  graphics/gmt: Update to 4.5.17

  lbartoletti@tuxfamily.org takes maintainership.

  Also changed to DISTVERSION.

  PR:		225786
  Submitted by:	lbartoletti@tuxfamily.org
  Approved by:	tcberner (mentor, implicit)

Changes:
  head/graphics/gmt/Makefile
  head/graphics/gmt/distinfo