Bug 225948 - [MAINTAINER UPDATE] www/phpsysinfo: update to 3.2.10
Summary: [MAINTAINER UPDATE] www/phpsysinfo: update to 3.2.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-16 10:48 UTC by Ralf van der Enden
Modified: 2018-02-25 05:38 UTC (History)
0 users

See Also:

Attachments
Update to 3.2.10 (32.46 KB, patch)
2018-02-16 10:48 UTC, Ralf van der Enden 		tremere: maintainer-approval+
Details | Diff
Update to 3.2.10 (with suggested changes by sunpoet@) (32.44 KB, patch)
2018-02-19 12:38 UTC, Ralf van der Enden 		tremere: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf van der Enden 2018-02-16 10:48:11 UTC 
Created attachment 190686 [details]
Update to 3.2.10

Removed files: pkg-plist

Pet portlint and move to dynamic PLIST

Changes:

3.2.10
- [UPD] jQuery 3.3.1
- [ADD] NuTyX to detected distros
- [FIX] Raid plugin - fixed zpool analize

3.2.9
- [UPD] Greek Translation gr.xml
- [ADD] BAT plugin - Model, Manufacturer and Serial Number information
- [ADD] BAT plugin - SHOW_SERIAL and UPOWER option
- [ADD] Springdale Linux to detected distros
- [NEW] SHOW_DEVICES_INFOS and SHOW_DEVICES_SERIAL options
- [NEW] Thinkpad - Lenovo Thinkpad sensors monitoring for Linux
- [NEW] StableBit plugin - StableBit Scanner info
- [NEW] HyperV plugin - Hyper-V info
- [NEW] Raid plugin - software, fake, zpool and megaraid RAID status
- [DEL] Removed deprecated MDStatus and DMRaid plugins
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-02-16 12:30:31 UTC 
The dynamic PLIST is not exactly the same as the static one. At least the @mode, @owner and @group keywords are missing.
Comment 2 Ralf van der Enden 2018-02-16 13:01:45 UTC 
(In reply to Sunpoet Po-Chuan Hsieh from comment #1)
You're right, but since phpsysinfo doesn't need write access to the files I decided to drop that.
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-02-19 09:39:27 UTC 
Ok, I see.

There are 2 issues:
1. You use "${FIND} | ${CPIO}" in do-install, I would suggest to remove .travis.yml and .gitignore in post-extract and use COPYTREE_SHARE to install files.
    cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR}

2. Regarding the dynamic PLIST, mixing "find -s" and "sort" is unnecessary.
    ${FIND} -s ${STAGEDIR}${WWWDIR} -not -type d | ${SORT}
Comment 4 Ralf van der Enden 2018-02-19 12:38:28 UTC 
Created attachment 190793 [details]
Update to 3.2.10 (with suggested changes by sunpoet@)


I've taken your suggestions and incorporated them into the Makefile, with one exception. Instead of removing the two files in post-extract, I've added find parameters to the COPYSHARE_TREE command to accomplish the same. (As shown in section 5.16.3 of https://www.freebsd.org/doc/en/books/porters-handbook/install.html)

Thanks for your tips. Hopefully this remedies all the issues to your satisfaction.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-02-25 05:32:39 UTC 
A commit references this bug:

Author: sunpoet
Date: Sun Feb 25 05:32:29 UTC 2018
New revision: 462911
URL: https://svnweb.freebsd.org/changeset/ports/462911

Log:
  Update to 3.2.10

  - While I'm here:
    - Sort USE_PHP
    - Fix PLIST_FILES

  Changes:	https://github.com/phpsysinfo/phpsysinfo/releases
  PR:		225948
  Submitted by:	Ralf van der Enden <tremere@cainites.net> (maintainer)

Changes:
  head/www/phpsysinfo/Makefile
  head/www/phpsysinfo/distinfo
  head/www/phpsysinfo/pkg-plist
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-02-25 05:38:45 UTC 
Committed. Thanks!