textproc/xlxhtml fails to make/build on [at least] CURRENT, with the following: ===> Building for xlhtml-0.5_4,1 gmake[2]: Entering directory '/usr/ports/textproc/xlhtml/work/xlhtml-0.5' cd . && aclocal aclocal-1.15: warning: autoconf input should be named 'configure.ac', not 'configure.in' cd . && automake --gnu Makefile automake-1.15: warning: autoconf input should be named 'configure.ac', not 'configure.in' configure.in:16: warning: AM_INIT_AUTOMAKE: two- and three-arguments forms are deprecated. For more info, see: configure.in:16: http://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_005fINIT_005fAUTOMAKE-invocation configure.in:19: error: required file './compile' not found configure.in:19: 'automake --add-missing' can install 'compile' gmake[2]: *** [Makefile:95: Makefile.in] Error 1 gmake[2]: Leaving directory '/usr/ports/textproc/xlhtml/work/xlhtml-0.5' ===> Compilation failed unexpectedly. Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to the maintainer. *** Error code 1 ... THE FIX: change the following line in the ports Makefile from USES= gmake tar:tgz to AUTOMAKE_ARGS+= --add-missing GNU_CONFIGURE= yes USES= gmake tar:tgz autoreconf pkgconfig and it builds, and installs as expected. --Chris
Created attachment 190975 [details] svn diff for textproc/xlhtml This time with a patch proper. Maintainer approval is implicit, as ports@ currently maintains it. --Chris
Comment on attachment 190975 [details] svn diff for textproc/xlhtml Port is unmaintained, implicit approval (pending QA)
(In reply to Kubilay Kocak from comment #2) > Comment on attachment 190975 [details] > svn diff for textproc/xlhtml > > Port is unmaintained, implicit approval (pending QA) patch tests fine on CURRENT (12). --Chris
I am not sure if AUTOMAKE_ARGS+=--add-missing is needed. This should do autoreconf. The warning comes always before autoreconf started.
(In reply to w.schwarzenfeld from comment #4) > I am not sure if AUTOMAKE_ARGS+=--add-missing is needed. This should do > autoreconf. The warning comes always before autoreconf started. I would have thought so too. But this was the only way I could get it to compile on -CURRENT. --Chris
==> configure.in:19: error: required file './compile' not found In this line is AC_PROG_CC => AC_PROG_CC ([compiler-search-list]) seems it does not find the compiler (?).
(In reply to w.schwarzenfeld from comment #6) > ==> configure.in:19: error: required file './compile' not found > > In this line is > AC_PROG_CC > > => AC_PROG_CC ([compiler-search-list]) > > seems it does not find the compiler (?). Indeed. But the svn diff attached to this pr(1) corrects that error/problem. :-) --Chris
Ok. It is sure a right solution. I cannot test on 12.X. I only want to know if it will configure if you add only add USES=compiler.
(In reply to w.schwarzenfeld from comment #8) > Ok. It is sure a right solution. > I cannot test on 12.X. I only want to know if it will configure if you add > only add USES=compiler. Ah, sure. OK. I'll give that a try, and report back with my findings on 12. :-) --Chris
Created attachment 193705 [details] svn diff for textproc/xlhtml (with requested changes) Here's a copy adding compiler to USES as you asked. I'm also including a QA LOG so you can see the results. --Chris
Created attachment 193706 [details] QA log for textproc/xlhtml QA LOG with the output from adding compiler to USES --Chris
Sorry, but think seems changed in the meantime. On my first try in february "compiler" solved, now it does not. Take your solution.
things instead of think....
Created attachment 194297 [details] xlhtml.diff Could you test this patch? The problem does not happen in Poudriere. The only difference I could find is regarding discovery of autotools. In Poudriere they are not installed in the build environment. But if they happen to be installed it triggers a regeneration of xlhtml's build files for some reason.
(In reply to Tobias Kortkamp from comment #14) > Created attachment 194297 [details] > xlhtml.diff > > Could you test this patch? The problem does not happen in Poudriere. > The only difference I could find is regarding discovery of autotools. > In Poudriere they are not installed in the build environment. But if > they happen to be installed it triggers a regeneration of xlhtml's > build files for some reason. Heh. I should have left well enough alone. :-) Sure. It's currently 1am here. So I'm going to bed. But should easily be able to provide something useful no later than Sunday. Thanks, Tobias! --Chris
Created attachment 194299 [details] svn diff for textproc/xlhtml with the requested changes ( v2 ) OK here's the diff I used with your requested changes, Tobias It build fine ( build LOG attached for your convenience ). But I must warn you; portlint wasn't pleased with your changes. ;-) --Chris
Created attachment 194300 [details] build LOG against the most recent diff OK here's the build LOG, as promised. Should have answers to any questions you may have. The only noteworthy output is at the bottom, regarding portlint. HTH --Chris
Can't seem to reproduce any build issue on CURRENT and the package builders show it building fine as well: http://beefy12.nyi.freebsd.org/data/head-amd64-default/p472509_s335244/logs/xlhtml-0.5_4,1.log Perhaps we can close this issue?
(In reply to Steve Wills from comment #18) As was said earlier it only happens outside of Poudriere and only when devel/autotools happens to be installed in the build environment. If you examine the logs you'll see that it tries to find and run aclocal, automake, autoheader during the build.
There is an "inofficial" update to 0.5.1 http://nebuchadnezzar.zion.cz/xlhtml.php I tried it quick. Seems it has not the config error. If it is wanted I can provide a svn-diff.
Btw, I have a working solution for recent version: patch-Makefile.in: --- Makefile.in.orig 2018-06-18 15:24:15 UTC +++ Makefile.in @@ -92,7 +92,7 @@ GZIP_ENV = --best all: all-redirect .SUFFIXES: $(srcdir)/Makefile.in: Makefile.am $(top_srcdir)/configure.in $(ACLOCAL_M4) - cd $(top_srcdir) && $(AUTOMAKE) --gnu Makefile + cd $(top_srcdir) && $(AUTOMAKE) --add-missing && $(AUTOMAKE) --gnu Makefile Makefile: $(srcdir)/Makefile.in $(top_builddir)/config.status $(BUILT_SOURCES) cd $(top_builddir) \ and adding CONFIGURE_ARGS+= --disable-dependency-tracking (for me I prefer the "unofficial" update).
A commit references this bug: Author: swills Date: Tue Jun 19 00:29:17 UTC 2018 New revision: 472723 URL: https://svnweb.freebsd.org/changeset/ports/472723 Log: textproc/xlhtml: Fix build when autotools is installed While here, strip binaries PR: 226080 Submitted by: Chris Hutchinson <portmaster@bsdforge.com> Changes: head/textproc/xlhtml/Makefile
Committed, thanks!