Bug 226164 - www/mod_pagespeed: Add Apache version prefix
Summary: www/mod_pagespeed: Add Apache version prefix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mahdi Mokhtari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-24 12:02 UTC by Bernard Spil
Modified: 2018-02-24 12:23 UTC (History)
0 users

See Also:
mmokhi: maintainer-feedback+

Attachments
svn diff for www/mod_pagespeed (541 bytes, patch)
2018-02-24 12:02 UTC, Bernard Spil 		mmokhi: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer freebsd_triage 2018-02-24 12:02:52 UTC 
Created attachment 190954 [details]
svn diff for www/mod_pagespeed

'''
www/mod_pagespeed: Add Apache version prefix

 - Prefix port with ap22- or ap24-

PR:
Approved by:
'''
Comment 1 Mahdi Mokhtari freebsd_committer freebsd_triage 2018-02-24 12:13:17 UTC 
Awesome :)
Thanks for the patch.
Feel free to commit it :), just a question, should we write something in UPDATING or MOVED files (because it changes PKGNAME) or it's fine as is?
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-02-24 12:16:45 UTC 
A commit references this bug:

Author: brnrd
Date: Sat Feb 24 12:16:23 UTC 2018
New revision: 462801
URL: https://svnweb.freebsd.org/changeset/ports/462801

Log:
  www/mod_pagespeed: Add Apache version prefix

   - Prefix port with ap22- or ap24-

  PR:		226164
  Approved by:	mmokhi (maintainer)

Changes:
  head/www/mod_pagespeed/Makefile
Comment 3 Bernard Spil freebsd_committer freebsd_triage 2018-02-24 12:17:48 UTC 
Hi Mahdi,

PKGNAME changes don't seem to break things. Executed the same for mod_http2-devel and mod_md-devel without issues (local or reported)
Comment 4 Mahdi Mokhtari freebsd_committer freebsd_triage 2018-02-24 12:23:17 UTC 
(In reply to Bernard Spil from comment #3)
Aha.
I learned new point :D Thanks a lot again __/||\__