Created attachment 191191 [details] Patch of devel/git-lfs diff from 2.3.4 to 2.4.0 Port devel/git-lfs diff from 2.3.4 to 2.4.0 Changes: https://github.com/git-lfs/git-lfs/releases/tag/v2.4.0 QA: poudriere testport passed for 10.4-RELEASE-p5 and 11.1-RELEASE-p6 both on i386 and amd64 architectures Fixes: * Set GOCACHE=off so that root/.cache is not created (Without this the poudriere build tests did not pass) See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226320 for the related discussions * Modify Makefile do-build label to respect the default env settings in Mk/Uses/go.mk
A lot of go ports fail with /root/.cache. portmgr should probably decide what should be generally done about this. Shouldn't just set GO_ENV+= GOCACHE=off everywhere.
(In reply to Yuri Victorovich from comment #1) Yes, I agree with you that the general /root/.cache should be handled by the portmgr. OTOH, this update also has a patch for the upstream update other than the GO_ENV stuff, so I'll keep it here anyway.
(In reply to Kenji Rikitake from comment #2) Yes, thanks. Need to wait until the general resolution.
(In reply to Yuri Victorovich from comment #3) This doesn't need to wait, why doesn't this port respect MAKE_ENV ?
(In reply to Antoine Brodin from comment #4) But does MAKE_ENV now solve this problem?
For some weird reason, I never saw this problem myself.
(In reply to Antoine Brodin from comment #4) I've fixed this port to respect MAKE_ENV and GO_ENV. See Makefile do-build label in the patch. Quote: -- quote from patch -- do-build: - cd ${WRKSRC} && ${MKDIR} ${WRKSRC}/.tmp && TMPDIR=${WRKSRC}/.tmp script/bootstrap + cd ${WRKSRC} && ${MKDIR} ${WRKSRC}/.tmp && ${SETENV} ${MAKE_ENV} ${GO_ENV} TMPDIR=${WRKSRC}/.tmp script/bootstrap -- quote ends here --
Kenji, Why does this port need RUN_DEPENDS bash?
(In reply to Yuri Victorovich from comment #8) It's been a while so I really don't remember about the reason why I added bash dependency, but I remember I did it when I rescued the port from the broken state. See: https://svnweb.freebsd.org/ports/head/devel/git-lfs/Makefile?r1=423051&r2=425729 https://svnweb.freebsd.org/ports?view=revision&revision=425729 Also, the script/bootstrap file has a bash dependency. See: https://github.com/git-lfs/git-lfs/blob/master/script/bootstrap
BUILD_DEPENDS isn't needed, it works with Bourn shell. I suspect it doesn't need run-time bash either, because it is just one binary executable.
Committed. Thank you for the update! (I am pretty sure that bash isn't needed during the runtime.)
A commit references this bug: Author: yuri Date: Sun Mar 4 07:04:37 UTC 2018 New revision: 463553 URL: https://svnweb.freebsd.org/changeset/ports/463553 Log: devel/git-lfs: Update to 2.4.0 Port changes: * Removed RUN_DEPENDS=bash (doesn't seem to be needed) * Silenced the do-build command * Renamed pre-install -> do-install * Use ${MAKE_ENV} and ${GO_ENV} PR: 226338 Submitted by: Kenji Rikitake <kenji@k2r.org> (maintainer) Approved by: tcberner (mentor, implicit) Changes: head/devel/git-lfs/Makefile head/devel/git-lfs/distinfo
(In reply to Yuri Victorovich from comment #10) Yes, I think you don't need bash to *run* this software. I agree with you. BTW thanks for the prompt update!
(In reply to Kenji Rikitake from comment #13) You're welcome!