Bug 226449 - [PATCH] devel/lua-posix: update to 34.0.4 and unbreak it
Summary: [PATCH] devel/lua-posix: update to 34.0.4 and unbreak it
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-03-08 13:15 UTC by Kai Knoblich
Modified: 2018-03-09 05:56 UTC (History)
1 user (show)

See Also:

Attachments
Patch to unbreak/update the port to 34.0.4 (2.42 KB, patch)
2018-03-08 13:15 UTC, Kai Knoblich 		no flags Details | Diff
Patch for lua-posix 34.0.4 / revision 2 (2.39 KB, patch)
2018-03-08 20:35 UTC, Kai Knoblich 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2018-03-08 13:15:15 UTC 
Created attachment 191307 [details]
Patch to unbreak/update the port to 34.0.4

Hello,

the patch unbreaks the ports and updates it to 34.0.4.

Changes to the port:
- changed PORTVERSION to DISTVERSION
- add LICENSE_FILE
- replaced GH_PROJECT and GH_ACCOUNT with appropriate GH_TUPLE
- updated pkg-plist
- removed  files/patch-lukefile (causes build failures)

QA:
~~~
- poudriere (11.1-RELEASE amd64 + i386) -> OK
- portlint -> OK
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-08 17:29:20 UTC 
FYI GH_TUPLE is to be used for adding extra projects or unbundling parts. Regular versions shouldn't use them.
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2018-03-08 20:35:01 UTC 
Created attachment 191318 [details]
Patch for lua-posix 34.0.4 / revision 2

Hello Yuri,

thanks for the clarification about the correct usage of GH_TUPLE. I created a revised patch which uses GH_ACCOUNT and GH_PROJECT instead.
--
Cheers
Kai
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-08 20:48:37 UTC 
Thank you for fixing it!

I will look in the evening.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-09 05:55:57 UTC 
Committed with changes.
Thank you for the update!
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-03-09 05:56:40 UTC 
A commit references this bug:

Author: yuri
Date: Fri Mar  9 05:55:54 UTC 2018
New revision: 463930
URL: https://svnweb.freebsd.org/changeset/ports/463930

Log:
  devel/lua-posix: Unbreak; Update to 34.0.4

  Port changes:
  * Changed to DISTVERSION
  * Added LICENSE_FILE
  * Simplified post-install

  PR:		226449
  Submitted by:	owk <freebsd_ports@k-worx.org>
  Approved by:	tcberner (mentor, implicit)

Changes:
  head/devel/lua-posix/Makefile
  head/devel/lua-posix/distinfo
  head/devel/lua-posix/files/
  head/devel/lua-posix/pkg-plist