Bug 226529 - audio/libechonest: add Qt 5 version
Summary: audio/libechonest: add Qt 5 version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sean Bruno
URL:
Keywords:
Depends on:
Blocks: 234534
  Show dependency tree / graph
 
Reported: 2018-03-11 17:31 UTC by Val Packett
Modified: 2019-01-03 21:45 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (nivit)

Attachments
libechonest-qt5.patch (2.51 KB, patch)
2018-03-11 17:31 UTC, Val Packett 		no flags Details | Diff
libechonest-qt5.patch v2 (FLAVORS) (3.93 KB, patch)
2018-04-17 12:36 UTC, Val Packett 		no flags Details | Diff
libechonest.patch (2.62 KB, patch)
2018-12-31 19:07 UTC, Val Packett 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2018-03-11 17:31:25 UTC 
Created attachment 191423 [details]
libechonest-qt5.patch

Necessary for the Qt 5 version of Clementine (https://github.com/clementine-player/Clementine/tree/qt5)
Comment 1 Val Packett 2018-04-17 12:36:38 UTC 
Created attachment 192591 [details]
libechonest-qt5.patch v2 (FLAVORS)

Now flavorized, similar to https://reviews.freebsd.org/D14667
Comment 2 Val Packett 2018-12-31 19:07:09 UTC 
Created attachment 200663 [details]
libechonest.patch

Since qt4 is deprecated, let's move to qt5 only.
Comment 3 Sean Bruno freebsd_committer freebsd_triage 2019-01-02 15:09:31 UTC 
Did a quick grep through the tree and it appears that Clementine is the only consumer (explicit consumer).  I'll take this to commit after compile/runtime tests are done here locally.

Thank you for the patch!
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-01-03 21:44:32 UTC 
A commit references this bug:

Author: sbruno
Date: Thu Jan  3 21:44:00 UTC 2019
New revision: 489228
URL: https://svnweb.freebsd.org/changeset/ports/489228

Log:
  audio/clementine-player:  Jump to qt5
  - regenerate some of the patch files for this new branch
  - cleanup and try to adjust Makefile

  audio/libechonest: Jump to qt5
  - clementine-player is the only port that I could find that has an explicit
    dependency on libechonest.  Commit this update so there is no window for
    build failures.

  Test built on 13-CURRENT, 12-STABLE, 11-STABLE across i386 and amd64.
  Run-time tested on 13-CURRENT, amd64.

  PR:		234534 226529
  Submitted by:	greg@unrelenting.technology

Changes:
  head/audio/clementine-player/Makefile
  head/audio/clementine-player/distinfo
  head/audio/clementine-player/files/patch-3rdParty_libprojectm_MilkdropPresetFactory_Parser.cpp
  head/audio/clementine-player/files/patch-3rdParty_libprojectm_Renderer_VideoEcho.cpp
  head/audio/clementine-player/files/patch-3rdparty_libprojectm_MilkdropPresetFactory_Parser.cpp
  head/audio/clementine-player/files/patch-3rdparty_libprojectm_Renderer_VideoEcho.cpp
  head/audio/clementine-player/files/patch-CMakeLists.txt
  head/audio/clementine-player/files/patch-dist_clementine.desktop
  head/audio/clementine-player/files/patch-src_CMakeLists.txt
  head/audio/clementine-player/pkg-plist
  head/audio/libechonest/Makefile
  head/audio/libechonest/pkg-plist
Comment 5 Sean Bruno freebsd_committer freebsd_triage 2019-01-03 21:45:38 UTC 
Greg:

If you see anything further that should/needs to be changed let me know.  I've fired this off based on your work.  Thank you.