Bug 226723 - net-mgmt/victorops-nagios: Add icinga2 configuration files
Summary: net-mgmt/victorops-nagios: Add icinga2 configuration files
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Luca Pizzamiglio
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2018-03-19 11:03 UTC by Luca Pizzamiglio
Modified: 2018-04-12 21:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (doug.rand)

Attachments
The patch (2.41 KB, patch)
2018-04-09 15:09 UTC, Luca Pizzamiglio 		pizzamig: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luca Pizzamiglio freebsd_committer freebsd_triage 2018-03-19 11:03:08 UTC 
With this patch, the port will install also icinga2 relevant configuration files.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-03-19 11:35:36 UTC 
Reporter is committer, assign accordingly

@Luca It looks like a patch is missing
Comment 2 Douglas K. Rand 2018-04-09 14:39:02 UTC 
Since the reporter is a ports committer, I'm not sure that that my approval is required. But on the odd chance that something or someone is waiting on it:

Approved.
Comment 3 Luca Pizzamiglio freebsd_committer freebsd_triage 2018-04-09 15:09:54 UTC 
Created attachment 192362 [details]
The patch

This patch add victorops icinga2 configuration files as weel
Comment 4 Luca Pizzamiglio freebsd_committer freebsd_triage 2018-04-09 15:13:46 UTC 
As committer, I can directly commit the PR, but I don't want to overstep the maintainer.
So the approval is needed.

Moreover, I completely forgot the patch, so now the maintainer can review it and set the flag to approve (if everything is fine).

I've tested the build on several FreeBSD version and everything looks fine.
Comment 5 Douglas K. Rand 2018-04-09 19:19:21 UTC 
Comment on attachment 192362 [details]
The patch

Looks good and straightforward to me.

Thanks for the patch, and the work!
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-04-12 21:03:34 UTC 
A commit references this bug:

Author: pizzamig
Date: Thu Apr 12 21:03:17 UTC 2018
New revision: 467197
URL: https://svnweb.freebsd.org/changeset/ports/467197

Log:
  net-mgmt/victorops-nagios: Add icinga2 configuration files

  PR:		226723
  Approved by:	rand@iteris.com (maintainer)
  Sponsored by:	trivago N.V.

Changes:
  head/net-mgmt/victorops-nagios/Makefile
  head/net-mgmt/victorops-nagios/pkg-plist