Created attachment 191700 [details] Update patch I have updated the slider panel plugin to a newer snapshot from it's source. I have chosen to grab the distribution from the github mirror, since this allowed me to use the USE_GITHUB helper. One big advantage is that this new version does not depend on the deprecated x11-toolkits/libxfce4gui component anymore. Since it's a in development plugin it does not provide a configure script but depends on devel/xfce4-dev-tools to generate the required parts. I have tested it in poudriere and running it on my laptop to control the screen brightness with success.
Thanks a lot for this quality patch! Committed with minor a modification: Unfortunately there is no install-strip install target so the stage-qa warning suggestion to use INSTALL_TARGET=install-strip won't work. You still get: Warning: 'lib/xfce4/panel/plugins/libgeneric-slider.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} I've changed the Makefile to manually strip the shared object in the post-install target.
A commit references this bug: Author: ehaupt Date: Thu Mar 22 08:26:45 UTC 2018 New revision: 465266 URL: https://svnweb.freebsd.org/changeset/ports/465266 Log: Update to a newer snapshot from it's source. Move to the official github mirror, since this allows to use the USE_GITHUB helper. Unfortunately this snapshot is not tagged so we have to use GH_TAGNAME. One big advantage is that this new version does not depend on the deprecated x11-toolkits/libxfce4gui component anymore. Since it's a in development plugin it does not provide a configure script but depends on devel/xfce4-dev-tools to generate the required parts. Move the two files from pkg-plist to PLIST_FILES. PR: 226821 Submitted by: madpilot Changes: head/deskutils/xfce4-generic-slider/Makefile head/deskutils/xfce4-generic-slider/distinfo head/deskutils/xfce4-generic-slider/pkg-plist
(In reply to Emanuel Haupt from comment #1) > Thanks a lot for this quality patch! > > Committed with minor a modification: Unfortunately there is no install-strip > install target so the stage-qa warning suggestion to use > INSTALL_TARGET=install-strip won't work. You still get: > > Warning: 'lib/xfce4/panel/plugins/libgeneric-slider.so' is not stripped > consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} > > I've changed the Makefile to manually strip the shared object in the > post-install target. Thanks for fixing this. It slipped by me, since make did not fail due to the missing target I assumed it was working properly!