Bug 226917 - security/tinc: broken man pages caused by non-portable syntax in Makefile
Summary: security/tinc: broken man pages caused by non-portable syntax in Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-25 15:56 UTC by Ting-Wei Lan
Modified: 2018-04-02 06:15 UTC (History)
0 users

See Also:
dinoex: maintainer-feedback+

Attachments
Fix man pages generation for tinc (2.34 KB, patch)
2018-03-25 15:56 UTC, Ting-Wei Lan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2018-03-25 15:56:44 UTC 
Created attachment 191805 [details]
Fix man pages generation for tinc

Tinc port installs two man pages, but both of them are empty.

$ gzip -l /usr/local/man/man8/tincd.8.gz 
  compressed uncompressed  ratio uncompressed_name
          20            0 -99.9% /usr/local/man/man8/tincd.8
$ gzip -l /usr/local/man/man5/tinc.conf.5.gz 
  compressed uncompressed  ratio uncompressed_name
          20            0 -99.9% /usr/local/man/man5/tinc.conf.5

The problem is in the Makefile of tinc. It causes sed to read input files from (empty) stdin and write empty outputs because our make implementation doesn't recognize '$<' in non-suffix rules. Upstream has fixed the problem in git, but no releases has been made since the fix was committed.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-04-02 06:14:24 UTC 
A commit references this bug:

Author: dinoex
Date: Mon Apr  2 06:13:32 UTC 2018
New revision: 466201
URL: https://svnweb.freebsd.org/changeset/ports/466201

Log:
  - fix content of manpages
  PR:		226917

Changes:
  head/security/tinc/Makefile
  head/security/tinc/files/patch-doc-Makefile.am
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2018-04-02 06:15:29 UTC 
Commited, Thanks.