Bug 227002 - mail/alpine update to 2.21.999
Summary: mail/alpine update to 2.21.999
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-27 17:22 UTC by Marco Beishuizen
Modified: 2018-03-28 22:33 UTC (History)
2 users (show)

See Also:
mbeis: maintainer-feedback+

Attachments
mail/alpine update to 2.21.999 (1.52 KB, patch)
2018-03-27 17:22 UTC, Marco Beishuizen 		mbeis: maintainer-approval+
Details | Diff
mail/alpine update to 2.21.999 (2.02 KB, patch)
2018-03-28 12:52 UTC, Marco Beishuizen 		mbeis: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Beishuizen 2018-03-27 17:22:21 UTC 
Created attachment 191875 [details]
mail/alpine update to 2.21.999

Update mail/alpine to latest version 2.21.999
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-27 19:04:23 UTC 
When all options are selected, stage-qa fails:
> Error: /usr/local/bin/alpine is linked to /usr/local/lib/libntlm.so.0 from security/libntlm but it is not declared as a dependency
> Warning: you need LIB_DEPENDS+=libntlm.so:security/libntlm

Please make sure stage-qa doesn't fail no matter what options are selected.
Comment 2 Marco Beishuizen 2018-03-27 19:59:06 UTC 
I can't reproduce this error here. Build and reinstalled, with all options on, on poudriere and my own machine (amd64).
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-27 20:03:26 UTC 
(In reply to Marco Beishuizen from comment #2)

You need to have security/libntlm installed.
Comment 4 Marco Beishuizen 2018-03-27 20:09:16 UTC 
Why would I install this library? Alpine doesn't need it.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-27 20:11:08 UTC 
Because it picks it up when it is installed.
This means that it can potentially link to it. This means that it might be needed.
Comment 6 Marco Beishuizen 2018-03-27 22:59:51 UTC 
Turns out that NTLM authentication support was added upstream. When security/libntlm is installed on the system, alpine is build with NTLM support.

I'll create a new Makefile with a build option for NTLM support.
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-27 23:05:23 UTC 
(In reply to Marco Beishuizen from comment #6)

And please also make sure that when this option is "off", it doesn't link to NTLM even if it is installed.
Comment 8 Marco Beishuizen 2018-03-28 12:52:26 UTC 
Created attachment 191905 [details]
mail/alpine update to 2.21.999

New diff:
- update alpine to 2.21.999
- added option for Windows NT Lan Manager authentication
Comment 9 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-28 22:33:12 UTC 
Committed.
Thank you for the update!
Comment 10 commit-hook freebsd_committer freebsd_triage 2018-03-28 22:33:43 UTC 
A commit references this bug:

Author: yuri
Date: Wed Mar 28 22:33:08 UTC 2018
New revision: 465849
URL: https://svnweb.freebsd.org/changeset/ports/465849

Log:
  mail/alpine: Update 2.21.1 -> 2.21.999

  Port changes:
  * Change to DISTVERSION
  * Remove unused MAILDIR_DESC
  * Add the new NTLM option to support Windows NT Lan Manager authentication
  * Replace WWW with the real homepage

  PR:		227002
  Submitted by:	Marco Beishuizen <mbeis@xs4all.nl> (maintainer)

Changes:
  head/mail/alpine/Makefile
  head/mail/alpine/distinfo
  head/mail/alpine/pkg-descr