Bug 227341 - sysutils/rubygem-r10k: Change default config location and pass maintainership to puppet@
Summary: sysutils/rubygem-r10k: Change default config location and pass maintainership...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ruby (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-07 11:37 UTC by Romain Tartière
Modified: 2018-07-24 06:50 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ruby)

Attachments
Patch to change default config location and change maintainer (1.86 KB, patch)
2018-04-07 11:37 UTC, Romain Tartière 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Tartière freebsd_committer freebsd_triage 2018-04-07 11:37:04 UTC 
Created attachment 192305 [details]
Patch to change default config location and change maintainer

Hello!

I would like to add a patch to fix the default location where r10k look for it's configuration file (it currently defaults to /etc/puppetlabs/r10k/r10k.yaml and /etc/r10k.yaml which do not make sense in respect to the FreeBSD hierarchy).

While here, passing maintainership to puppet@ may help us better track problems with r10k integration with the rest of the Puppet ports.  If you don't mind about this, we would be happy to take care of it.

Thanks!
Romain, with puppet@ hat
Comment 1 Steve Wills freebsd_committer freebsd_triage 2018-07-23 22:26:51 UTC 
Looks good, go for it (with ruby@ hat).
Comment 2 Romain Tartière freebsd_committer freebsd_triage 2018-07-24 06:40:58 UTC 
Awesome!

Just saw that  I had hardcoded /usr/local instead of using PREFIX correctly.  Will fix that when committing!

Thanks
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-07-24 06:48:28 UTC 
A commit references this bug:

Author: romain
Date: Tue Jul 24 06:47:49 UTC 2018
New revision: 475227
URL: https://svnweb.freebsd.org/changeset/ports/475227

Log:
  Add a patch to search for configuration files under PREFIX, e.g.

  /usr/local/etc/r10k/r10k.yaml
  /usr/local/etc/r10k.yaml

  While here, pass maintainership to puppet@

  PR:		227341
  Submitted by:	romain
  Approved by:	swills (with ruby hat)

Changes:
  head/sysutils/rubygem-r10k/Makefile
  head/sysutils/rubygem-r10k/files/patch-lib_r10k_settings_loader.rb