Bug 227856 - print/muttprint: Unbreak with recent version of perl
Summary: print/muttprint: Unbreak with recent version of perl
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Romain Tartière
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-29 17:56 UTC by Romain Tartière
Modified: 2018-04-30 06:22 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (guru)


Attachments
Fix (921 bytes, patch)
2018-04-29 18:00 UTC, Romain Tartière
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Tartière freebsd_committer freebsd_triage 2018-04-29 17:56:15 UTC

    
Comment 1 Romain Tartière freebsd_committer freebsd_triage 2018-04-29 18:00:08 UTC
Created attachment 192914 [details]
Fix

muttprint will not work with Perl 5.26 and die with the following message:

perl Unescaped left brace in regex is illegal here in regex


According to https://unix.stackexchange.com/questions/238539/automake-error-unescaped-left-brace-in-regex-is-deprecated#238708 escaping { and } produced a warning with Perl 5.22+ and now fails with Perl 5.26.

The attached patch fix the issue.  A PORTREVISION bump is also included.
Comment 2 Matthias Apitz 2018-04-30 05:38:57 UTC
I'm still on perl version perl5-5.24.1. I checked the patch and applied it. It works file too with 5.24.

The proposed patch should be ci'ed.
Comment 3 Romain Tartière freebsd_committer freebsd_triage 2018-04-30 06:14:48 UTC
Take it!
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-04-30 06:18:45 UTC
A commit references this bug:

Author: romain
Date: Mon Apr 30 06:17:52 UTC 2018
New revision: 468672
URL: https://svnweb.freebsd.org/changeset/ports/468672

Log:
  Unbreak with recent version of Perl

  PR:		227856
  Submitted by:	romain
  Approved by:	Matthias Apitz <guru@unixarea.de> (maintainer)

Changes:
  head/print/muttprint/Makefile
  head/print/muttprint/files/patch-muttprint
Comment 5 Romain Tartière freebsd_committer freebsd_triage 2018-04-30 06:22:48 UTC
Committed, thanks!