Bug 228020 - mail/roundcube-thunderbird_labels broken - distfile size difference and missing rcmail-thunderbird-labels-1.1.4
Summary: mail/roundcube-thunderbird_labels broken - distfile size difference and missi...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-06 12:05 UTC by dewayne
Modified: 2018-08-01 04:25 UTC (History)
2 users (show)

See Also:
moiseev: maintainer-feedback+
pi: merge-quarterly+


Attachments
patch for mail/roundcube-thunderbird_labels (1.23 KB, patch)
2018-05-07 06:29 UTC, Alexander Moisseev
moiseev: maintainer-approval+
Details | Diff
patch for mail/roundcube-contextmenu (1.13 KB, patch)
2018-05-07 06:30 UTC, Alexander Moisseev
moiseev: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewayne 2018-05-06 12:05:50 UTC
The downloaded size differs from distfiles 
SIZE (mike-kfed-rcmail-thunderbird-labels-v1.1.4_GH0.tar.gz) = 184884
is 
-rw-r--r--  1 root  wheel  184886 May  6 21:49 /distfiles/mike-kfed-rcmail-thunderbird-labels-v1.1.4_GH0.tar.gz

The package build attempts to use 
===>   Generating temporary packing list
cd /var/ports/usr/ports/mail/roundcube-thunderbird_labels/work-php56/rcmail-thunderbird-labels-1.1.4 && /bin/sh -c '(/usr/bin/find -Ed $1 $3 | /usr/bin/cpio -dumpl $2 >/dev/null 2>&1) &&  /usr/bin/find -Ed $1 $3 \(   -type d -exec /bin/sh -c '\''cd '\''$2'\'' && chmod 755 "$@"'\'' . {} +  -o -type f -exec /bin/sh -c '\''cd '\''$2'\'' && chmod 0644 "$@"'\'' . {} + \)' COPYTREE_SHARE . /var/ports/usr/ports/mail/roundcube-thunderbird_labels/work-php56/stage/usr/local/www/roundcube/plugins/thunderbird_labels
cd: /var/ports/usr/ports/mail/roundcube-thunderbird_labels/work-php56/rcmail-thunderbird-labels-1.1.4: No such file or directory
*** Error code 2

but what exists is:
/var/ports/usr/ports/mail/roundcube-thunderbird_labels/work-php56/roundcube-thunderbird_labels-1.1.4

Seems to be a few problems with this port???
Comment 1 dewayne 2018-05-06 12:12:45 UTC
Additional info: 
# svnlite update /usr/ports/mail/roundcube-thunderbird_labels
Updating '/usr/ports/mail/roundcube-thunderbird_labels':
At revision 469193.
# uname -pivKU
FreeBSD 11.1-STABLE  r329008M  i386 hqdev-amd64-smp-vga 1101509 1101509
Comment 2 Alexander Moisseev 2018-05-06 13:02:19 UTC
I cannot reproduce the issues.

BTW, If cached source file is broken then the port system should refetch it automatically.
Comment 3 dewayne 2018-05-06 22:09:39 UTC
(In reply to Alexander Moisseev from comment #2)
That's very interesting.  When I delete my mike-kfed-rcmail-thunderbird-labels-v1.1.4_GH0.tar.gz
and perform
 make -C usr/ports/mail/roundcube-thunderbird_labels fetch          
I obtain
-rw-r--r--  1 root  wheel  184886 May  7 08:06 /distfiles/mike-kfed-rcmail-thunderbird-labels-v1.1.4_GH0.tar.gz

but you obtain a file that's 184884 in size.  I'm using curl to fetch, so this is quite a mystery.
Comment 4 Alexander Moisseev 2018-05-07 06:26:01 UTC
Ah, I see. Upstream has renamed their GitHub repository.
Comment 5 Alexander Moisseev 2018-05-07 06:29:24 UTC
Created attachment 193135 [details]
patch for mail/roundcube-thunderbird_labels

mail/roundcube-thunderbird_labels: Update GH_PROJECT as the upstream repository has been renamed.
Comment 6 Alexander Moisseev 2018-05-07 06:30:45 UTC
Created attachment 193136 [details]
patch for mail/roundcube-contextmenu

mail/roundcube-contextmenu: Update GH_PROJECT as the upstream repository has been renamed.
Comment 7 dewayne 2018-07-30 22:40:24 UTC
(In reply to Alexander Moisseev from comment #6)
Thanks Alexander, though the file sizes are roughly the same, the descriptions are quite different? (or perhaps I need to install roundcube's context menu)

Interestingly thunderbird-labels fails to build on FreeBSD 11.2 with 
===>   Generating temporary packing list
cd /var/ports/usr/ports/mail/roundcube-thunderbird_labels/work-php56/rcmail-thunderbird-labels-1.1.4 && /bin/sh -c '(/usr/bin/find -Ed $1 $3 | /usr/bin/cpio -dumpl $2 >/dev/null 2>&1) &&  /usr/bin/find -Ed $1 $3 \(   -type d -exec /bin/sh -c '\''cd '\''$2'\'' && chmod 755 "$@"'\'' . {} +  -o -type f -exec /bin/sh -c '\''cd '\''$2'\'' && chmod 0644 "$@"'\'' . {} + \)' COPYTREE_SHARE . /var/ports/usr/ports/mail/roundcube-thunderbird_labels/work-php56/stage/usr/local/www/roundcube/plugins/thunderbird_labels
cd: /var/ports/usr/ports/mail/roundcube-thunderbird_labels/work-php56/rcmail-thunderbird-labels-1.1.4: No such file or directory
*** Error code 2

And contextmenu does (build) - so there's motivation...

Though I thought it odd that the download from 
https://codeload.github.com/JohnDoh/Roundcube-Plugin-Context-Menu/tar.gz/2.3?dummy=/JohnDoh-Roundcube-Plugin-Context-Menu-2.3_GH0.tar.gz
resulted in
=> Fetched file size mismatch (expected 39642, actual 39626)
but the next site 
http://distcache.FreeBSD.org/ports-distfiles/JohnDoh-Roundcube-Plugin-Context-Menu-2.3_GH0.tar.gz
was successful per /usr/ports/mail/roundcube-contextmenu/distinfo

So should mail/roundcube-thunderbird_labels be removed and Mk/UPDATING reflect the change to mail/roundcube-contextmenu?
Comment 8 Alexander Moisseev 2018-07-31 07:23:01 UTC
(In reply to dewayne from comment #7)
The patches attached to this PR are not committed yet. They should fix the issue with source fetching, but for now you need to apply them by yourself.

I can't reproduce the problem with build on FreeBSD 11.2. Probably it is specific to your environment.

I don't understand why should mail/roundcube-thunderbird_labels be removed? I suppose mail/roundcube-thunderbird_labels and mail/roundcube-contextmenu are two different plugins. You can have them both or just one of them. It depends on your needs.
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2018-07-31 12:03:30 UTC
testbuilds@work
Comment 10 commit-hook freebsd_committer freebsd_triage 2018-07-31 17:14:44 UTC
A commit references this bug:

Author: pi
Date: Tue Jul 31 17:14:26 UTC 2018
New revision: 476008
URL: https://svnweb.freebsd.org/changeset/ports/476008

Log:
  mail/roundcube-thunderbird_labels: unbreak: distsite moved inside github

  PR:		228020
  MFH:		2018Q3
  Submitted by:	Alexander Moiseev <moiseev@mezonplus.ru> (maintainer)
  Reported by:	dewayne@heuristicsystems.com.au

Changes:
  head/mail/roundcube-thunderbird_labels/Makefile
  head/mail/roundcube-thunderbird_labels/distinfo
Comment 11 commit-hook freebsd_committer freebsd_triage 2018-07-31 17:16:52 UTC
A commit references this bug:

Author: pi
Date: Tue Jul 31 17:16:08 UTC 2018
New revision: 476009
URL: https://svnweb.freebsd.org/changeset/ports/476009

Log:
  mail/roundcube-contextmenu: unbreak: upstream distsite moved inside github

  PR:		228020
  MFH:		2018Q3
  Submitted by:	Alexander Moiseev <moiseev@mezonplus.ru> (maintainer)
  Reported by:	dewayne@heuristicsystems.com.au

Changes:
  head/mail/roundcube-contextmenu/Makefile
  head/mail/roundcube-contextmenu/distinfo
Comment 12 commit-hook freebsd_committer freebsd_triage 2018-08-01 04:24:06 UTC
A commit references this bug:

Author: pi
Date: Wed Aug  1 04:23:13 UTC 2018
New revision: 476148
URL: https://svnweb.freebsd.org/changeset/ports/476148

Log:
  MFH: r476008

  mail/roundcube-thunderbird_labels: unbreak: distsite moved inside github

  PR:		228020
  Submitted by:	Alexander Moiseev <moiseev@mezonplus.ru> (maintainer)
  Reported by:	dewayne@heuristicsystems.com.au
  Approved by:	ports-secteam (miwi)

Changes:
_U  branches/2018Q3/
  branches/2018Q3/mail/roundcube-thunderbird_labels/Makefile
  branches/2018Q3/mail/roundcube-thunderbird_labels/distinfo
Comment 13 commit-hook freebsd_committer freebsd_triage 2018-08-01 04:24:10 UTC
A commit references this bug:

Author: pi
Date: Wed Aug  1 04:24:03 UTC 2018
New revision: 476149
URL: https://svnweb.freebsd.org/changeset/ports/476149

Log:
  MFH: r476009

  mail/roundcube-contextmenu: unbreak: upstream distsite moved inside github

  PR:		228020
  Submitted by:	Alexander Moiseev <moiseev@mezonplus.ru> (maintainer)
  Reported by:	dewayne@heuristicsystems.com.au
  Approved by:	ports-secteam (miwi)

Changes:
_U  branches/2018Q3/
  branches/2018Q3/mail/roundcube-contextmenu/Makefile
  branches/2018Q3/mail/roundcube-contextmenu/distinfo
Comment 14 Kurt Jaeger freebsd_committer freebsd_triage 2018-08-01 04:25:55 UTC
Committed, thanks!