Bug 228057 - devel/gogs: Add dependency on bash
Summary: devel/gogs: Add dependency on bash
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kirill Ponomarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-08 03:48 UTC by Nathan Reilly
Modified: 2018-05-09 20:23 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (dmgk)

Attachments
Add shells/bash runtime dependendency (517 bytes, patch)
2018-05-08 22:34 UTC, Dmitri Goutnik 		dmgk: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Reilly 2018-05-08 03:48:56 UTC 
Hello,

Per https://gogs.io/docs/intro/troubleshooting (at the bottom), gogs requires bash for the hook scripts. It is not currently listed as a dependency for gogs in this port.

Thanks,
Nathan
Comment 1 Dmitri Goutnik freebsd_committer freebsd_triage 2018-05-08 22:34:40 UTC 
Created attachment 193194 [details]
Add shells/bash runtime dependendency
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-05-09 17:46:34 UTC 
A commit references this bug:

Author: krion
Date: Wed May  9 17:45:38 UTC 2018
New revision: 469456
URL: https://svnweb.freebsd.org/changeset/ports/469456

Log:
  Add shells/bash dependency as it's required by gogs hooks scripts.

  PR:		228057
  Submitted by:	maintainer

Changes:
  head/devel/gogs/Makefile
Comment 3 Ivan 2018-05-09 20:23:09 UTC 
This is wrong. Gogs hooks are autogenerated with SCRIPT_TYPE value for shebang. Any interpreter can be set here. Better to revert this patch.