Bug 228100 - sysutils/ods2 [PATCH] and request maintainership
Summary: sysutils/ods2 [PATCH] and request maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-09 15:56 UTC by Oleg P.
Modified: 2018-05-10 14:26 UTC (History)
0 users

See Also:


Attachments
include patch-ods2 patch-direct.c patch-Makefile (4.11 KB, text/plain)
2018-05-09 15:56 UTC, Oleg P.
no flags Details
Solved some issue (2.93 KB, text/plain)
2018-05-09 16:10 UTC, Oleg P.
no flags Details
Solved a warning while compile (821 bytes, text/plain)
2018-05-09 16:14 UTC, Oleg P.
no flags Details
Change e-mail address (315 bytes, text/plain)
2018-05-09 16:16 UTC, Oleg P.
no flags Details
[PATCH] svn diff (patch-ods2.c patch-direct.c Makefile) (5.00 KB, patch)
2018-05-10 06:03 UTC, Oleg P.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg P. 2018-05-09 15:56:47 UTC
Created attachment 193211 [details]
include patch-ods2 patch-direct.c patch-Makefile

1. Patch ods2.c
  - keeping older patch;
  - was solver issue with trailing spaces and/or tabs
    (for example: if you enter a COMMAND and then enter a few
     spaces or tabs, then you will get an error);
  - parsing command line.
2. Patch direct.c - was solved a warning while compile this file.
3. I would like to become the maintainer of this port since it's unmaintained.
Comment 1 Oleg P. 2018-05-09 16:10:17 UTC
Created attachment 193212 [details]
Solved some issue

- keeping older patch;
- was solver issue with trailing spaces and/or tabs
  (for example: if you enter a COMMAND and then enter a few
  spaces or tabs, then you will get an error);
- parsing command line.
Comment 2 Oleg P. 2018-05-09 16:14:01 UTC
Created attachment 193213 [details]
Solved a warning while compile

Patch direct.c - was solved a warning while compile this file.
Comment 3 Oleg P. 2018-05-09 16:16:10 UTC
Created attachment 193214 [details]
Change e-mail address

Request maintainership.
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-05-09 17:13:51 UTC
Thank you for the effort but please consolidate all patches into a single
unified diff that we can apply with `svn patch` and mark the old attachments
as obsolete.  `svn diff` in the ports directory will generate such a patch.

Right now it's a bit of mess that's hard to follow.
Comment 5 Oleg P. 2018-05-09 19:17:25 UTC
Forgive me please I am a newer in the bugzilla.
Comment 6 Oleg P. 2018-05-10 06:03:08 UTC
Created attachment 193225 [details]
[PATCH] svn diff (patch-ods2.c patch-direct.c Makefile)

1. Patch ods2.c
  - keeping older patch;
  - was solver issue with trailing spaces and/or tabs
    (for example: if you enter a COMMAND and then enter a few
     spaces or tabs, then you will get an error);
  - parsing command line.
2. Patch direct.c - was solved a warning while compile this file.
3. I would like to become the maintainer of this port since it's unmaintained.
Comment 7 Oleg P. 2018-05-10 06:04:19 UTC
Comment on attachment 193225 [details]
[PATCH] svn diff (patch-ods2.c patch-direct.c Makefile)

1. Patch ods2.c
  - keeping older patch;
  - was solver issue with trailing spaces and/or tabs
    (for example: if you enter a COMMAND and then enter a few
     spaces or tabs, then you will get an error);
  - parsing command line.
2. Patch direct.c - was solved a warning while compile this file.
3. I would like to become the maintainer of this port since it's unmaintained.
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2018-05-10 14:09:56 UTC
LGTM. Thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-05-10 14:26:18 UTC
A commit references this bug:

Author: tobik
Date: Thu May 10 14:26:07 UTC 2018
New revision: 469549
URL: https://svnweb.freebsd.org/changeset/ports/469549

Log:
  sysutils/ods2: New maintainer

  - Assign to submitter
  - Fix some issues with
    - trailing spaces and/or tabs (for example: if you enter a COMMAND
      and then enter a few spaces or tabs, then you will get an error)
    - parsing command line
    - some compiler warnings
  - While here simplify DOCS installation

  PR:		228100
  Submitted by:	Oleg P. <pzn.unixbsd@gmail.com>

Changes:
  head/sysutils/ods2/Makefile
  head/sysutils/ods2/files/patch-direct.c
  head/sysutils/ods2/files/patch-ods2.c