Created attachment 193301 [details] svn diff for devel/tcl-trf I installed this, and noticed it had a couple problems. So I fixed them. :-) CHANGES o add LICENSE o pet portlint -- add a ${STRIP_CMD} to strip lib(s) portlint still whines about the patchfiles that accompany this port (not made with makepatch). But I'll leave that to the MAINTAINER. :-) That's it! --Chris See svn diff && QA LOG attached, for details.
Created attachment 193302 [details] QA LOG for devel/tcl-trf transcript for build of devel/tcl-trf includes the ports framework output.
(In reply to Chris Hutchinson from comment #0) Hi. I couldn't find any references for BSD2CLAUSE license. > work/trf2.1.4/doc/license.terms it seems some TCL license variation.
(In reply to Danilo G. Baio from comment #2) > (In reply to Chris Hutchinson from comment #0) > > Hi. > I couldn't find any references for BSD2CLAUSE license. > > > work/trf2.1.4/doc/license.terms > it seems some TCL license variation. I took the information from LSM in the root of the source: Copying-policy: BSD-Style, see 'tcl'-license So I guess either "policy" could be considered "valid". But I'm not the MAINTAINER. I was only trying to help. :-) You're probably correct. So in case you were wondering; I didn't find an actual BSD 2 clause license included anywhere. HTH --Chris
(In reply to Chris Hutchinson from comment #3) > (In reply to Danilo G. Baio from comment #2) > > (In reply to Chris Hutchinson from comment #0) > > > > Hi. > > I couldn't find any references for BSD2CLAUSE license. > > > > > work/trf2.1.4/doc/license.terms > > it seems some TCL license variation. > > I took the information from LSM in the root of the > source: > > Copying-policy: BSD-Style, see 'tcl'-license > > So I guess either "policy" could be considered "valid". > But I'm not the MAINTAINER. I was only trying to help. :-) > You're probably correct. So in case you were wondering; > I didn't find an actual BSD 2 clause license included > anywhere. > > HTH > > --Chris OK just found the license I used to base my decision on (doc/license.terms): This software is copyrighted by Andreas Kupries. The following terms apply to all files associated with the software unless explicitly disclaimed in individual files. The author hereby grant permission to use, copy, modify, distribute, and license this software and its documentation for any purpose, provided that existing copyright notices are retained in all copies and that this notice is included verbatim in any distributions. No written agreement, license, or royalty fee is required for any of the authorized uses. Modifications to this software may be copyrighted by their authors and need not follow the licensing terms described here, provided that the new terms are clearly indicated on the first page of each file where they apply. IN NO EVENT SHALL THE AUTHOR OR DISTRIBUTORS BE LIABLE TO ANY PARTY FOR DIRECT, INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OF THIS SOFTWARE, ITS DOCUMENTATION, OR ANY DERIVATIVES THEREOF, EVEN IF THE AUTHOR HAVE BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THE AUTHOR AND DISTRIBUTORS SPECIFICALLY DISCLAIM ANY WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, AND NON-INFRINGEMENT. THIS SOFTWARE IS PROVIDED ON AN "AS IS" BASIS, AND THE AUTHOR AND DISTRIBUTORS HAVE NO OBLIGATION TO PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. Reads a lot like BSD2CLAUSE. No? --Chris
Neither BS2CLAUSE or TCL/TK. https://opensource.org/licenses/BSD-2-Clause https://www.tcl.tk/software/tcltk/license.html It has the same permissions, but for me, it's a customized license. LICENSE= Tcl_Trf_License LICENSE_NAME= Tcl Trf License LICENSE_FILE= ${WRKSRC}/doc/license.terms LICENSE_PERMS= dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
Created attachment 193366 [details] version 2 of svn diff for devel/tcl-trf Here ya go; an updated svn diff based on your preferences. HTH --Chris
A commit references this bug: Author: dbaio Date: Sun May 13 20:51:29 UTC 2018 New revision: 469830 URL: https://svnweb.freebsd.org/changeset/ports/469830 Log: devel/tcl-trf: Add LICENSE Strip libTrf2.1.4.so (Q/A warning) PR: 228179 Submitted by: Chris Hutchinson <portmaster@bsdforge.com> Approved by: portmgr (blanket) Changes: head/devel/tcl-trf/Makefile
Committed, thanks!