Bug 228236 - japanese/another-htmllint: Change dependecy from www/p5-CGI.pm to www/p5-CGI
Summary: japanese/another-htmllint: Change dependecy from www/p5-CGI.pm to www/p5-CGI
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-14 06:56 UTC by Yasuhiro Kimura
Modified: 2018-06-18 13:10 UTC (History)
4 users (show)

See Also:
yasu: maintainer-feedback? (kuriyama)


Attachments
patch file (712 bytes, patch)
2018-05-14 06:56 UTC, Yasuhiro Kimura
no flags Details | Diff
updated patch file (1.10 KB, patch)
2018-05-16 09:00 UTC, Yasuhiro Kimura
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2018-05-14 06:56:19 UTC
Created attachment 193378 [details]
patch file

Change dependecy from www/p5-CGI.pm to www/p5-CGI because

* www/p5-CGI and www/p5-CGI.pm provide same functions and conflict each other.
* While a lot of ports use www/p5-CGI, only this one uses www/p5-CGI.pm.
* By swiching to use www/p5-CGI this port and others can be installed together.
Comment 1 Yasuhiro Kimura freebsd_committer freebsd_triage 2018-05-14 07:10:37 UTC
(In reply to Yasuhiro KIMURA from comment #0)

Build succeeds with poudriere and 11.1-RELEASE amd64 jail. And it works fine on my real 11.1-RELEASE amd64 home server environment.
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2018-05-16 00:15:32 UTC
Do you want to take maintainership?  The previous patch you submit timed more than 3 months, actually 6 months. You can take it if you want.
Comment 3 Yasuhiro Kimura freebsd_committer freebsd_triage 2018-05-16 09:00:31 UTC
Created attachment 193448 [details]
updated patch file

(In reply to Koichiro Iwao from comment #2)

Thank you for proposal.
I'll take maintainership of this port if current maintainer agrees with it.
So I updated patch to change mail address of MAINTAINER.
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2018-05-17 00:29:52 UTC
(In reply to Yasuhiro KIMURA from comment #3)
It's OK to take maintainership without approval because maintainer seems to be absent for long. Just in case, let's wait maintainer timeout again (2 weeks). Then I'll commit it.
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2018-06-01 13:01:37 UTC
Hi Steve,
I was going to commit this but feel free to commit it as you've already working on this. It takes some time for me to commit this because I'm still being mentored.
Comment 6 Yasuhiro Kimura freebsd_committer freebsd_triage 2018-06-16 02:08:26 UTC
Iwao-san,

Would you please commit this bug report with maintainer timeout?

Best Regards.
Comment 7 Koichiro Iwao freebsd_committer freebsd_triage 2018-06-16 08:12:45 UTC
(In reply to Yasuhiro KIMURA from comment #6)
Okay, I'll commit it.
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-06-18 13:07:28 UTC
A commit references this bug:

Author: meta
Date: Mon Jun 18 13:06:39 UTC 2018
New revision: 472686
URL: https://svnweb.freebsd.org/changeset/ports/472686

Log:
  japanese/another-htmllint: Change dependecy from www/p5-CGI.pm to www/p5-CGI

  www/p5-CGI and www/p5-CGI.pm provide same functions and conflict each other.
  While a lot of ports use www/p5-CGI, only this one uses www/p5-CGI.pm. By
  swiching to use www/p5-CGI this port and others can be installed together.

  Also, pass maintainership to the submitter due to consecutive maintainer
  timeouts.

  PR:		228236
  Submitted by:	Yasuhiro KIMURA <yasu@utahime.org>
  Approved by:	maintainer timeout,  pi (mentor)

Changes:
  head/japanese/another-htmllint/Makefile
Comment 9 Koichiro Iwao freebsd_committer freebsd_triage 2018-06-18 13:10:18 UTC
Committed, thanks!