Bug 228264 - [NEW PORT] net/py-haproxyctl: HAProxy control tool
Summary: [NEW PORT] net/py-haproxyctl: HAProxy control tool
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords: easy, feature
Depends on:
Blocks:
 
Reported: 2018-05-15 04:50 UTC by TAO ZHOU
Modified: 2018-05-18 05:03 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback+

Attachments
new port net/haproxyctl (1.48 KB, text/plain)
2018-05-15 04:50 UTC, TAO ZHOU 		no flags Details
new port net/haproxyctl (1.49 KB, text/plain)
2018-05-15 06:27 UTC, TAO ZHOU 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description TAO ZHOU 2018-05-15 04:50:05 UTC 
Created attachment 193411 [details]
new port net/haproxyctl

Creating a new port net/py-haroxyctl.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-05-15 05:17:24 UTC 
If/when a Python package supports > 1 python versions, as most python packages do, and also provides scripts (in LOCALBASE/bin, as this does), the port should be made concurrent safe (using USE_PYTHON=concurrent) so those files are uniquely named and do not conflict when multiple versions are installed
Comment 2 TAO ZHOU 2018-05-15 06:27:01 UTC 
Created attachment 193415 [details]
new port net/haproxyctl

I just added USE_PYTHON = concurrent and attached a new patch.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2018-05-15 08:21:08 UTC 
Other review items (already resolved in my working copy):

- Space -> tabs (portlint -AC)
- Missing PYTHON_PKGNAMEPREFIX
- Add TEST_DEPENDS and test target where tests/when are provided in sources
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2018-05-15 08:28:00 UTC 
@Tao Also the MAINTAINER line must match the maintainers Bugzilla email.

Would you like to change your Bugzilla email address to match the MAINTAINER line in attachment 193415 [details], or vice-versa?
Comment 5 TAO ZHOU 2018-05-16 00:02:55 UTC 
@Kubilay,
I would like to use my bugzilla email as the maintainer.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2018-05-16 02:24:31 UTC 
(In reply to TAO ZHOU from comment #5)

Thanks, I'll take care of updating the patch
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-05-18 04:31:27 UTC 
A commit references this bug:

Author: koobs
Date: Fri May 18 04:30:25 UTC 2018
New revision: 470262
URL: https://svnweb.freebsd.org/changeset/ports/470262

Log:
  [NEW] net/py-haproxyctl: HAProxy control tool

  HAProxyctl is a tool to manage the various aspects of HAProxy that can be
  controlled by means of its socket.

  HAProxyctl can be used in 2 modes. CLI mode and Python API mode. CLI mode,
  as the name implies, gives you a command, haproxyctl, that can be used to
  control HAProxy. You can use the Python API mode to integrate HAProxyctl
  directly in your Python project.

  WWW: https://github.com/neurogeek/haproxyctl

  PR:		228264
  Submitted by:	Tao Zhou <zhoutao laocius org>

Changes:
  head/net/Makefile
  head/net/py-haproxyctl/
  head/net/py-haproxyctl/Makefile
  head/net/py-haproxyctl/distinfo
  head/net/py-haproxyctl/pkg-descr
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2018-05-18 05:03:02 UTC 
Committed with changes. Thank you Tao!