Bug 229053 - textproc/ibus: upgrade to 1.5.18
Summary: textproc/ibus: upgrade to 1.5.18
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-15 19:46 UTC by Thierry Thomas
Modified: 2018-09-22 10:32 UTC (History)
1 user (show)

See Also:
henry.hu.sh: maintainer-feedback+


Attachments
Patch to upgrade ibus to the latest (7.16 KB, patch)
2018-07-10 16:05 UTC, Thierry Thomas
thierry: maintainer-approval? (henry.hu.sh)
Details | Diff
add test target, fix pkg-plist (7.17 KB, patch)
2018-08-25 22:05 UTC, Henry Hu
henry.hu.sh: maintainer-approval+
Details | Diff
overriding do-test target (7.22 KB, patch)
2018-08-25 22:14 UTC, Henry Hu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2018-06-15 19:46:51 UTC
Upgrade ibus to the latest.

Release notes at
https://github.com/ibus/ibus/releases/tag/1.5.18
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2018-07-10 16:05:14 UTC
Created attachment 195031 [details]
Patch to upgrade ibus to the latest

Sorry, it seems that I forgot the patch with my initial PR!

BTW, why do you disable tests? All tests pass fine (with gmake and an Unicode locale as en_US.UTF8)
Comment 2 Henry Hu 2018-08-02 03:10:32 UTC
(In reply to Thierry Thomas from comment #1)
Because I think that most users do not want to run tests. I can add a TEST option and default it to off, so anyone who wants to run tests can enable it.
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2018-08-10 17:13:31 UTC
(In reply to Henry Hu from comment #2)
A test: target is not automatically launched, the user needs to run `make test'. At some point, tools like poudriere could enable it, but ASAIK, this is to yet done.
Comment 4 Henry Hu 2018-08-25 22:05:49 UTC
Created attachment 196546 [details]
add test target, fix pkg-plist

I've added the test target. However, the tests do not pass on my system. There's a problem related to GVFS volume monitor.
Comment 5 Henry Hu 2018-08-25 22:14:41 UTC
Created attachment 196547 [details]
overriding do-test target

It seems like that do-test target is more appropriate.
Comment 6 Thierry Thomas freebsd_committer freebsd_triage 2018-09-22 10:32:05 UTC
Committed with your latest patch and some minor modifications to pet portlint.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-09-22 10:32:32 UTC
A commit references this bug:

Author: thierry
Date: Sat Sep 22 10:32:06 UTC 2018
New revision: 480377
URL: https://svnweb.freebsd.org/changeset/ports/480377

Log:
  upgrade to 1.5.18.

  Release notes at
  https://github.com/ibus/ibus/releases/tag/1.5.18

  PR:		229053
  Approved by:	maintainer

Changes:
  head/textproc/ibus/Makefile
  head/textproc/ibus/distinfo
  head/textproc/ibus/files/patch-configure
  head/textproc/ibus/pkg-descr
  head/textproc/ibus/pkg-message
  head/textproc/ibus/pkg-plist