Bug 229075 - mail/*notmuch*: update to 0.27
Summary: mail/*notmuch*: update to 0.27
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-16 21:55 UTC by Sebastian Schwarz
Modified: 2018-06-19 19:30 UTC (History)
1 user (show)

See Also:
seschwar: maintainer-feedback+


Attachments
notmuch-0.27.patch (5.80 KB, patch)
2018-06-16 21:55 UTC, Sebastian Schwarz
no flags Details | Diff
notmuch-0.27.patch (7.20 KB, patch)
2018-06-17 11:50 UTC, Sebastian Schwarz
seschwar: maintainer-approval+
Details | Diff
notmuch-0.27.patch (7.29 KB, patch)
2018-06-17 21:31 UTC, Sebastian Schwarz
seschwar: maintainer-approval+
Details | Diff
notmuch-0.27.patch (7.92 KB, patch)
2018-06-18 17:59 UTC, Sebastian Schwarz
seschwar: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Schwarz 2018-06-16 21:55:39 UTC
Created attachment 194315 [details]
notmuch-0.27.patch

notmuch 0.27 was released recently: https://notmuchmail.org/pipermail/notmuch/2018/026684.html

Apart from upstream bug fixes and enhancements mentioned in the release notes linked above the following changes have been made to the port:

- remove BROKEN_powerpc64 since the cause has been fixed in ports r471400
- adjust to upstream's new info page handling
- fix parallel installation of flavored mail/py-notmuch

Everything builds fine under Poudriere on FreeBSD:11:amd64.  Portlint complains a bit, but only because it doesn't understand master/slave ports well.
Comment 1 Sebastian Schwarz 2018-06-17 11:50:20 UTC
Created attachment 194331 [details]
notmuch-0.27.patch

Updated the patch to re-add jrm@freebsd.org's original patch to remove bashisms from the notmuch-emacs-mua script.  It got lost during the master/slave port conversion.
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2018-06-17 20:11:54 UTC
A testbuild on 10.4i386 fails to build for mail/notmuch. See

http://people.freebsd.org/~pi/logs/mail__notmuch-104i.txt

Should this work ?
Comment 3 Sebastian Schwarz 2018-06-17 21:31:17 UTC
Created attachment 194341 [details]
notmuch-0.27.patch

I did move a patch around between master and slave port and apparently forgot to do a full final test.  The attached patch should fix that.  I hope this time I tested it correctly.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2018-06-17 21:42:28 UTC
New build-test still fails. Same URL, new build-log...
Comment 5 Sebastian Schwarz 2018-06-17 22:12:00 UTC
It's the same error as before, right?

> make -C doc/_build/texinfo info
> make[2]: illegal argument to -j -- must be positive integer!

The error is caused by "make" getting called instead of "gmake".  That's what should be fixed by this: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=194341&action=diff#mail/notmuch/files/patch-doc_Makefile.local_sec1

Are you sure you used the updated patch I uploaded?

I'll give this some more testing with Poudriere on FreeBSD:10:i386 tomorrow.
Comment 6 Sebastian Schwarz 2018-06-18 17:59:13 UTC
Created attachment 194369 [details]
notmuch-0.27.patch

So I tested the ports using Poudriere testport on FreeBSD:10:i386 and got the following error:

> ====> Running Q/A tests (stage-qa)
> ====> Checking for pkg-plist issues (check-plist)
> ===> Parsing plist
> ===> Checking for items in STAGEDIR missing from pkg-plist
> Error: Orphaned: info/notmuch-address.info
> Error: Orphaned: info/notmuch-compact.info
> Error: Orphaned: info/notmuch-config.info
> Error: Orphaned: info/notmuch-count.info
> Error: Orphaned: info/notmuch-dump.info
> Error: Orphaned: info/notmuch-emacs-mua.info
> Error: Orphaned: info/notmuch-emacs.info
> Error: Orphaned: info/notmuch-hooks.info
> Error: Orphaned: info/notmuch-insert.info
> Error: Orphaned: info/notmuch-new.info
> Error: Orphaned: info/notmuch-properties.info
> Error: Orphaned: info/notmuch-reindex.info
> Error: Orphaned: info/notmuch-reply.info
> Error: Orphaned: info/notmuch-restore.info
> Error: Orphaned: info/notmuch-search-terms.info
> Error: Orphaned: info/notmuch-search.info
> Error: Orphaned: info/notmuch-show.info
> Error: Orphaned: info/notmuch-tag.info
> Error: Orphaned: info/notmuch.info
> ===> Checking for items in pkg-plist which are not in STAGEDIR
> ===> Error: Plist issues found.

Notmuch's configure script auto-detects whether it should build the info pages.  FreeBSD 10 still has texinfo in base, triggering the build of the info pages even if we don't want them.

I've added a fix for this in the attached patch and the ports now pass Poudriere's testbuild on both FreeBSD:10:i386 and FreeBSD:11:amd64.

Kurt, can you confirm that the port works for you now?
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2018-06-19 19:27:57 UTC
Yes, testbuilds are fine now.
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2018-06-19 19:29:42 UTC
Committed, thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-06-19 19:30:22 UTC
A commit references this bug:

Author: pi
Date: Tue Jun 19 19:29:34 UTC 2018
New revision: 472817
URL: https://svnweb.freebsd.org/changeset/ports/472817

Log:
  mail/notmuch,mail/notmuch-emacs,mail/py-notmuch: update 0.26.2 -> 0.27

  - add LICENSE to pet portlint
  - remove BROKEN_powerpc64 since the cause has been fixed in ports r471400
  - adjust to upstream's new info page handling
  - fix parallel installation of flavored mail/py-notmuch

  PR:		229075
  Submitted by:	Sebastian Schwarz <seschwar@gmail.com> (maintainer)
  Relnotes:	https://notmuchmail.org/pipermail/notmuch/2018/026684.html

Changes:
  head/mail/notmuch/Makefile
  head/mail/notmuch/distinfo
  head/mail/notmuch/files/
  head/mail/notmuch/files/patch-doc_Makefile.local
  head/mail/notmuch/files/patch-emacs_notmuch-emacs-mua
  head/mail/notmuch/pkg-plist
  head/mail/notmuch-emacs/Makefile
  head/mail/notmuch-emacs/files/
  head/mail/notmuch-emacs/files/patch-doc_Makefile.local
  head/mail/notmuch-emacs/files/patch-emacs_notmuch-emacs-mua
  head/mail/py-notmuch/Makefile