Bug 229084 - [New port] databases/p5-HTML-FormHandler-Model-DBIC
Summary: [New port] databases/p5-HTML-FormHandler-Model-DBIC
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-17 09:21 UTC by Tomohiro Hosaka
Modified: 2019-01-05 19:35 UTC (History)
2 users (show)

See Also:
vovkasm: maintainer-feedback+

Attachments
svn diff (2.94 KB, patch)
2018-06-17 09:21 UTC, Tomohiro Hosaka 		no flags Details | Diff
svn diff -- update to 0.29 (2.26 KB, patch)
2018-06-19 07:32 UTC, Tomohiro Hosaka 		no flags Details | Diff
svn diff (2.29 KB, patch)
2018-06-19 09:22 UTC, Tomohiro Hosaka 		no flags Details | Diff
svn diff (2.04 KB, patch)
2018-06-23 04:36 UTC, Tomohiro Hosaka 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomohiro Hosaka 2018-06-17 09:21:48 UTC 
Created attachment 194328 [details]
svn diff

* portlint ok
* poudriere testport ok (11.1, amd64, svn-head)
* make test ok
Comment 1 Vladimir Timofeev 2018-06-17 09:29:43 UTC 
Do you want to maintain that port in future? If yes, I totally ok with this.

Anyway it should be update request, isn't it?
Comment 2 Tomohiro Hosaka 2018-06-17 09:56:50 UTC 
Thank you for your review.

What I am sending is what I have been updating in local repository for several years already.

Even if I quit using it, I will update it for a while.

However, because it is used in multiple productions, it seems that I can not quit. ^ ^;;

Perl has another very good tool such as cpanminus.
However, the use of pkg -j etc is convenient and ultra fast, so I like the package.
Comment 3 Tomohiro Hosaka 2018-06-19 07:32:37 UTC 
Created attachment 194386 [details]
svn diff -- update to 0.29

> Anyway it should be update request, isn't it?

That's right.
I mistook it as a new port.
I'm sorry.

I made a patch again.

Please review again.
Comment 4 Vladimir Timofeev 2018-06-19 08:05:35 UTC 
Looks good for me (I'am already set mainteiner-feedback field to '+'). Now we should wait while someone with commit rights pay attention on this request.

Moreover, I'm totally ok if you want to be maintainer of this port (I'm not using HTML::FormHandler actively for 3-4 years), to do this you need to modify MAINTAINER field in Makefile in you patch.
Comment 5 Tomohiro Hosaka 2018-06-19 09:22:12 UTC 
Created attachment 194395 [details]
svn diff

Thank you for your reply.

I still use it actively.

I modified the MAINTAINER= line.

Thank you very much.
Comment 6 Tomohiro Hosaka 2018-06-23 04:36:44 UTC 
Created attachment 194525 [details]
svn diff

NO_ARCH=yes added.
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-01-05 19:35:19 UTC 
A commit references this bug:

Author: swills
Date: Sat Jan  5 19:34:19 UTC 2019
New revision: 489369
URL: https://svnweb.freebsd.org/changeset/ports/489369

Log:
  databases/p5-HTML-FormHandler-Model-DBIC: update to 0.29

  While here, give maintainership to submitter

  PR:		229084
  Submitted by:	Tomohiro Hosaka <bokutin@bokut.in>
  Approved by:	Vladimir Timofeev <vovkasm@gmail.com> (maintainer)

Changes:
  head/databases/p5-HTML-FormHandler-Model-DBIC/Makefile
  head/databases/p5-HTML-FormHandler-Model-DBIC/distinfo
Comment 8 Steve Wills freebsd_committer freebsd_triage 2019-01-05 19:35:54 UTC 
Committed, thanks!