Bug 229237 - www/nginx and brotli. Keep temporary files opened forever
Summary: www/nginx and brotli. Keep temporary files opened forever
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-22 19:29 UTC by Alexey
Modified: 2018-07-07 07:56 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (joneum)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey 2018-06-22 19:29:00 UTC 
Hello!

Current version on 3-rdp module BROTLI for nginx in ports tree have a problem, in some configurations, for example when on fly compression enabled and content come from upstream, working process keep temporary files opened after request ended. After some while it uses all possible opened file descriptors and stop make new connections to upstream

This bug was fixed some time ago at upstream 
https://github.com/eustas/ngx_brotli/commit/e26248ee361c04e25f581b92b85d95681bdffb39

(it changed NGX_DONE to NGX_OK at end, so other modules got chance to finish their work also, close files, for example)

Looks like we need to change version of module from 37ab9b2 to e26248e or add such patch to ports tree.

Discussion on nginx forum (sorry, in russian only) https://forum.nginx.org/read.php?21,280196,280221#msg-280221
Comment 1 Jochen Neumeister freebsd_committer freebsd_triage 2018-06-23 18:26:54 UTC 
Hey Alexey,

thanks for the PR, i will take have a look :-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-06-28 17:28:15 UTC 
A commit references this bug:

Author: joneum
Date: Thu Jun 28 17:27:29 UTC 2018
New revision: 473502
URL: https://svnweb.freebsd.org/changeset/ports/473502

Log:
  - Update brotli to e26248e
  - Fix STREAM_SSL_PREREAD

  PR:		229336, 229237

Changes:
  head/www/nginx/Makefile
  head/www/nginx/Makefile.extmod
  head/www/nginx/distinfo
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2018-06-28 17:32:43 UTC 
Landed. Thanks :-)
Comment 4 Alexey 2018-07-05 21:13:15 UTC 
Hello!

Our tests show, problem is solved. Thank you!

br
/Alexey
Comment 5 Jochen Neumeister freebsd_committer freebsd_triage 2018-07-07 07:56:42 UTC 
(In reply to Alexey from comment #4)

thanks for your feedback and you're Report, Alexey! :-)