Bug 229244 - [PATCH] www/squid-devel configure error when IPFILTER option selected
Summary: [PATCH] www/squid-devel configure error when IPFILTER option selected
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-23 03:47 UTC by Cy Schubert
Modified: 2018-06-29 22:32 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (timp87)
cy: maintainer-feedback?

Attachments
Fixes errant line break in call to ac_fn_cxx_check_member() (2.91 KB, patch)
2018-06-23 04:25 UTC, Cy Schubert 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cy Schubert freebsd_committer freebsd_triage 2018-06-23 03:47:55 UTC 

    


    


      



        
          Comment 1
        

        
          Cy Schubert

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-06-23 04:25:48 UTC
        

      






Created attachment 194520 [details]
Fixes errant line break in call to ac_fn_cxx_check_member()

The patch fixes an errant line break that caused not enough arguments to be passed to ac_fn_cxx_check_member().

    


    


      



        
          Comment 2
        

        
          Cy Schubert

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-06-23 04:27:14 UTC
        

      






Example of the error:

checking for struct natlookup.nl_inipaddr.in6... no
checking for struct natlookup.nl_realipaddr.in6... eval: ${+...}: Bad substitution
===>  Script "configure" failed unexpectedly.
Please report the problem to timp87@gmail.com [maintainer] and attach the
"/export/wrkdir/amd64/export/home/cy/freebsd/git/ports/www/squid-devel/work/squid-4.0.25/config.log"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Stop.
make[1]: stopped in /export/home/cy/freebsd/git/ports/www/squid-devel
*** Error code 1

Stop.
make: stopped in /export/home/cy/freebsd/git/ports/www/squid-devel

    


    


      



        
          Comment 3
        

        
          Cy Schubert

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-06-23 04:27:34 UTC
        

      






Please approve the patch.

    


    


      



        
          Comment 4
        

        
          Pavel Timofeev

        

        
        

        
          2018-06-29 07:45:09 UTC
        

      






Comment on attachment 194520 [details]
Fixes errant line break in call to ac_fn_cxx_check_member()

no objections

    


    


      



        
          Comment 5
        

        
          Cy Schubert

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-06-29 21:28:55 UTC
        

      






Thanks. I'll commit this shortly.

    


    


      



        
          Comment 6
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-06-29 21:36:19 UTC
        

      






A commit references this bug:

Author: cy
Date: Fri Jun 29 21:36:04 UTC 2018
New revision: 473583
URL: https://svnweb.freebsd.org/changeset/ports/473583

Log:
  Fix a configure error when the IPFILTER option is selected. An example
  of the error is:

  checking for struct natlookup.nl_inipaddr.in6... no
  checking for struct natlookup.nl_realipaddr.in6... eval: ${+...}: Bad substitution
  ===>  Script "configure" failed unexpectedly.
  Please report the problem to timp87@gmail.com [maintainer] and attach the
  "/export/wrkdir/amd64/export/home/cy/freebsd/git/ports/www/squid-devel/work/squid-4.0.25/config.log"
  including the output of the failure of your make command. Also, it might be
  a good idea to provide an overview of all packages installed on your system
  (e.g. a /usr/local/sbin/pkg-static info -g -Ea).
  *** Error code 1

  Stop.
  make[1]: stopped in /export/home/cy/freebsd/git/ports/www/squid-devel
  *** Error code 1

  Stop.
  make: stopped in /export/home/cy/freebsd/git/ports/www/squid-devel

  PR:		229244
  Submitted by:	cy
  Reported by:	cy
  Approved by:	Maintainer <timp87@gmail.com>

Changes:
  head/www/squid-devel/files/patch-configure

    


    


      



        
          Comment 7
        

        
          Cy Schubert

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-06-29 22:32:25 UTC
        

      






Thanks. The patch has been committed. Thanks again.