Bug 229780 - math/cvc4: update to 1.6
Summary: math/cvc4: update to 1.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-15 00:12 UTC by Val Packett
Modified: 2018-07-22 18:30 UTC (History)
1 user (show)

See Also:

Attachments
cvc4.patch (8.48 KB, patch)
2018-07-15 00:12 UTC, Val Packett 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2018-07-15 00:12:42 UTC 
Created attachment 195132 [details]
cvc4.patch

Now with cryptominisat, with python build dependency, without gexpr (coreutils) build dependency.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-07-21 15:59:07 UTC 
Fails on 10i386:
/usr/include/c++/v1/__tree:656:59: error: static_cast from '__node_pointer' (aka 'std::__1::__tree_node<std::__1::__value_type<CVC4::NodeTemplate<false>, CVC4::theory::quantifiers::TermArgTrie>, void *> *') to '__node_base_pointer' (aka 'std::__1::__tree_node_base<void *> *') is not allowed
        {__ptr_ = static_cast<__node_pointer>(__tree_next(static_cast<__node_base_pointer>(__ptr_)));
                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/v1/map:680:35: note: in instantiation of member function 'std::__1::__tree_iterator<std::__1::__value_type<CVC4::NodeTemplate<false>, CVC4::theory::quantifiers::TermArgTrie>, std::__1::__tree_node<std::__1::__value_type<CVC4::NodeTemplate<false>, CVC4::theory::quantifiers::TermArgTrie>, void *> *, int>::operator++' requested here
    __map_iterator& operator++() {++__i_; return *this;}
                                  ^
/usr/include/c++/v1/map:685:9: note: in instantiation of member function 'std::__1::__map_iterator<std::__1::__tree_iterator<std::__1::__value_type<CVC4::NodeTemplate<false>, CVC4::theory::quantifiers::TermArgTrie>, std::__1::__tree_node<std::__1::__value_type<CVC4::NodeTemplate<false>, CVC4::theory::quantifiers::TermArgTrie>, void *> *, int> >::operator++' requested here
        ++(*this);
        ^
Comment 2 Val Packett 2018-07-22 09:57:11 UTC 
(In reply to Yuri Victorovich from comment #1)

hm. I guess you could try a newer compiler

.if ${COMPILER_TYPE} == clang && ${COMPILER_VERSION} < 40
BUILD_DEPENDS+=	clang40:devel/llvm40
CC=		clang40
CXX=		clang++40
.endif
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-07-22 18:30:34 UTC 
Committed with changes.
Thank you for your update!
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-07-22 18:30:54 UTC 
A commit references this bug:

Author: yuri
Date: Sun Jul 22 18:30:30 UTC 2018
New revision: 475115
URL: https://svnweb.freebsd.org/changeset/ports/475115

Log:
  math/cvc4: Update 1.5 -> 1.6

  Port changes:
  * Add dependency on cryptominisat, and the corresponding port option
  * Add USES=autoreconf, the suplied configure fails, see https://github.com/CVC4/CVC4/issues/2192
  * Now build depends on python
  * Force clang-60 to prevent build failures on 10

  PR:		229780
  Submitted by:	Greg V <greg@unrelenting.technology>

Changes:
  head/math/cvc4/Makefile
  head/math/cvc4/distinfo
  head/math/cvc4/files/patch-config_cryptominisat.m4
  head/math/cvc4/files/patch-configure.ac
  head/math/cvc4/files/patch-src_base_configuration.cpp
  head/math/cvc4/pkg-plist