Bug 229848 - emulators/fmsx: Update to 5.4 and unbreak/undeprecate
Summary: emulators/fmsx: Update to 5.4 and unbreak/undeprecate
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-17 21:15 UTC by Kai Knoblich
Modified: 2018-07-18 11:37 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (dk)

Attachments
fmsx-5.4.patch (6.34 KB, patch)
2018-07-17 21:15 UTC, Kai Knoblich 		no flags Details | Diff
fmsx-5.4-rev2.patch (7.09 KB, patch)
2018-07-18 06:12 UTC, Kai Knoblich 		kai: maintainer-approval? (dk)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2018-07-17 21:15:20 UTC 
Created attachment 195219 [details]
fmsx-5.4.patch

Hello,

attached is the patch that updates emulators/fmsx to 5.4 and unbreaks/undeprecates it.

Changes by upstream:
- (5.4) http://fms.komkon.org/fMSX/fMSX.html#LABA
- (5.3 and older versions) http://fms.komkon.org/fMSX/fMSX.html#LABB

Changes to the port:
- changed DIST_SUBDIR from "fmsx4" to "fmsx5"
- added audio/pulseaudio to LIB_DEPENDS
- added LICENSE info
- sorted USES/USE variables to pet portlint
- changed/rebased patches in files/
- updated pkg-plist


QA:
~~~
- poudriere (11.2-RELEASE amd64 + i386) -> OK
- portlint -> OK
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-07-17 22:40:45 UTC 
(In reply to Kai from comment #0)
Why does the license suddenly have auto-accept, pkg-mirror, dist-mirror?  The
port still has RESTRICTED in it.  I doubt that it no longer applies.

Any reason to make PulseAudio mandatory now?  AFAICT it still has
OSS suport in it, so please make it optional.
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2018-07-18 06:12:06 UTC 
Created attachment 195230 [details]
fmsx-5.4-rev2.patch

(In reply to Tobias Kortkamp from comment #1)

Thank you for your feedback. Attached is a revised patch that includes your suggestions:

- LICENSE_PERMS are now fully restricted
- Pulseaudio is upstream's new default since 5.1 but it's now optional and not enabled by default.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-07-18 11:37:41 UTC 
A commit references this bug:

Author: tobik
Date: Wed Jul 18 11:36:47 UTC 2018
New revision: 474854
URL: https://svnweb.freebsd.org/changeset/ports/474854

Log:
  emulators/fmsx: Update to 5.4

  - Reset maintainer; the port has been broken for over 5 months and
    there have been > 3 timeouts before (going as far back as 2004)
    so the current maintainer seems to not be interested anymore.

  PR:		229848
  Submitted by:	Kai <freebsd_ports@k-worx.org>

Changes:
  head/emulators/fmsx/Makefile
  head/emulators/fmsx/distinfo
  head/emulators/fmsx/files/patch-EMULib_Rules.Unix
  head/emulators/fmsx/files/patch-EMULib_Rules.gcc
  head/emulators/fmsx/pkg-plist