Bug 229963 - x11-themes/xfce-evolution: Update to 4.12.0
Summary: x11-themes/xfce-evolution: Update to 4.12.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-22 15:42 UTC by J.R. Oldroyd
Modified: 2018-07-28 19:04 UTC (History)
1 user (show)

See Also:

Attachments
patch to update port from 4.10.1 to 4.11.2 (38.26 KB, patch)
2018-07-22 15:42 UTC, J.R. Oldroyd 		no flags Details | Diff
patch to update port from 4.11.2 to 4.12.0 (27.96 KB, patch)
2018-07-28 13:57 UTC, J.R. Oldroyd 		no flags Details | Diff
patch to update port from 4.10.1 to 4.12.0 (57.62 KB, patch)
2018-07-28 14:34 UTC, J.R. Oldroyd 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description J.R. Oldroyd 2018-07-22 15:42:23 UTC 
Created attachment 195373 [details]
patch to update port from 4.10.1 to 4.11.2
Comment 1 J.R. Oldroyd 2018-07-28 13:57:05 UTC 
Created attachment 195530 [details]
patch to update port from 4.11.2 to 4.12.0
Comment 2 Jochen Neumeister freebsd_committer freebsd_triage 2018-07-28 14:06:14 UTC 
Hey J.R. Oldroyd :-)

can you please upload a diff with a update from 4.10.1 to 4.12.0?

Thx :-)
Comment 3 J.R. Oldroyd 2018-07-28 14:34:45 UTC 
Created attachment 195534 [details]
patch to update port from 4.10.1 to 4.12.0
Comment 4 J.R. Oldroyd 2018-07-28 14:38:03 UTC 
(In reply to Jochen Neumeister from comment #2)

I have just done so, but I would point out that I have submitted sequences of diffs like this before without issues, see PR#229315.  Is it no longer possible to run multiple patches?

May I ask why these take so long to be committed?  It has been a week now since I submitted the 4.11.2 update and, in that time, several minor changes have been made to the PR itself, but the patch was not yet committed.  I do my best to ensure that the patches pass portlint and check-plist in order for it to be possible to commit them without issues.  Is there something else I should be doing in order to ensure quicker committing?
Comment 5 Jochen Neumeister freebsd_committer freebsd_triage 2018-07-28 14:57:55 UTC 
(In reply to J.R. Oldroyd from comment #4)

I am human :-)
I have a job, a family. The days was unfortunately much on work. So my hobby FreeBSD had to wait a bit. Excuse me for that. It is not my intention to leave commits long. Unfortunately, it happens from time to time. I am currently working on this.

It's okay if you upload 2 patches. A new one would be great. It's not a "must", just a "would be nice" ;-)

I will work on your PR right now. Again sorry for the delay. :-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-07-28 19:03:33 UTC 
A commit references this bug:

Author: joneum
Date: Sat Jul 28 19:03:15 UTC 2018
New revision: 475601
URL: https://svnweb.freebsd.org/changeset/ports/475601

Log:
  x11-themes/xfce-evolution: Update to 4.12.0

  PR:		229963
  Submitted by:	J.R. Oldroyd <fbsd@opal.com> (maintainer)

Changes:
  head/x11-themes/xfce-evolution/Makefile
  head/x11-themes/xfce-evolution/distinfo
  head/x11-themes/xfce-evolution/pkg-plist
Comment 7 Jochen Neumeister freebsd_committer freebsd_triage 2018-07-28 19:04:33 UTC 
Landed. Thanks :-)