Bug 229984 - www/py-tornado: Add missing dependency
Summary: www/py-tornado: Add missing dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Grzegorz Blach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-23 16:32 UTC by Joseph Mingrone
Modified: 2018-07-23 17:29 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gblach)

Attachments
Add (485 bytes, patch)
2018-07-23 16:32 UTC, Joseph Mingrone 		jrm: maintainer-approval? (gblach)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Mingrone freebsd_committer freebsd_triage 2018-07-23 16:32:32 UTC 
Created attachment 195393 [details]
Add

When trying to run the latest www/py-notebook, it complained that tornado was missing the futures dependency.  I also used pip to install tornado and saw that it installed futures.  It also installed six.  Should six also be added as a dependency?
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-07-23 17:26:49 UTC 
A commit references this bug:

Author: gblach
Date: Mon Jul 23 17:26:35 UTC 2018
New revision: 475190
URL: https://svnweb.freebsd.org/changeset/ports/475190

Log:
  Add devel/py-futures to RUN_DEPENDS when python is older than 3.2

  PR:		229984
  Submitted by:	jrm

Changes:
  head/www/py-tornado/Makefile
Comment 2 Grzegorz Blach freebsd_committer freebsd_triage 2018-07-23 17:28:42 UTC 
Committed with minor change, thanks.
Comment 3 Grzegorz Blach freebsd_committer freebsd_triage 2018-07-23 17:29:32 UTC 
BTW: six is a dependency of futures not tornado.