Bug 230020 - [PATCH] chinese/pcmanx: Fix the code that incorrectly trim URL.
Summary: [PATCH] chinese/pcmanx: Fix the code that incorrectly trim URL.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Li-Wen Hsu
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-07-24 17:12 UTC by holishing
Modified: 2018-08-11 08:31 UTC (History)
3 users (show)

See Also:

Attachments
patched for this port. (1.30 KB, text/plain)
2018-07-24 17:12 UTC, holishing 		no flags Details
note that there is a port revision (378 bytes, patch)
2018-07-24 17:14 UTC, holishing 		no flags Details | Diff
correct the place of revision words (378 bytes, patch)
2018-07-24 17:16 UTC, holishing 		no flags Details | Diff
merged patches for this port. (2.27 KB, patch)
2018-07-26 00:53 UTC, holishing 		no flags Details | Diff
merged patches for this port. (2.27 KB, patch)
2018-07-26 00:55 UTC, holishing 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description holishing 2018-07-24 17:12:37 UTC 
Created attachment 195427 [details]
patched for this port.

It is bug fix patch from upstream(master branch):
https://github.com/pcman-bbs/pcmanx/pull/69

but there is no any release plan (for e.g. PCManX v1.4) in upstream team.
even though this is an apparent problem.

and fix a compilation error effected in clang v6.0.x .
Comment 1 holishing 2018-07-24 17:14:05 UTC 
Created attachment 195428 [details]
note that there is a port revision
Comment 2 holishing 2018-07-24 17:16:48 UTC 
Created attachment 195429 [details]
correct the place of revision words
Comment 3 holishing 2018-07-26 00:53:08 UTC 
Created attachment 195459 [details]
merged patches for this port.

merged 2 files into single patch for more convenient to test it.
Comment 4 holishing 2018-07-26 00:55:57 UTC 
Created attachment 195460 [details]
merged patches for this port.

merged patches for this port.

merged 2 files into single patch for more convenient to test it.

(correct details)
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-08-11 08:31:44 UTC 
A commit references this bug:

Author: lwhsu
Date: Sat Aug 11 08:30:56 UTC 2018
New revision: 476861
URL: https://svnweb.freebsd.org/changeset/ports/476861

Log:
  - Added a patch in upstream but not release yet to fix the code that
    incorrectly trim URL [1]
  - Sort patches
  - Pet portlint

  PR:		230020 [1]
  Submitted by:	holishing <holishingtest@gmail.com>

Changes:
  head/chinese/pcmanx/Makefile
  head/chinese/pcmanx/files/patch-configure
  head/chinese/pcmanx/files/patch-src-mainframe.cpp
  head/chinese/pcmanx/files/patch-src-pcmanx_gtk2.cpp
  head/chinese/pcmanx/files/patch-src-view-telnetcon.cpp