Bug 230058 - net-mgmt/nstat: don't assume timespecadd is undefined
Summary: net-mgmt/nstat: don't assume timespecadd is undefined
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-26 14:48 UTC by Alan Somers
Modified: 2018-07-27 20:59 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (swills)
asomers: merge-quarterly?

Attachments
Fix build if timespecadd is already defined (832 bytes, patch)
2018-07-26 14:48 UTC, Alan Somers 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2018-07-26 14:48:55 UTC 
Created attachment 195475 [details]
Fix build if timespecadd is already defined

A change to base will soon expose timespecadd(3) to userspace.  nstat should not assume that it is undefined.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-07-26 17:55:13 UTC 
A commit references this bug:

Author: swills
Date: Thu Jul 26 17:54:36 UTC 2018
New revision: 475392
URL: https://svnweb.freebsd.org/changeset/ports/475392

Log:
  net-mgmt/nstat: don't assume timespecadd is undefined

  PR:		230058
  Submitted by:	asomers

Changes:
  head/net-mgmt/nstat/files/
  head/net-mgmt/nstat/files/patch-nstat.c
Comment 2 Steve Wills freebsd_committer freebsd_triage 2018-07-26 17:55:38 UTC 
Committed, but can you please send this upstream too? Thanks!
Comment 3 Alan Somers freebsd_committer freebsd_triage 2018-07-26 18:14:42 UTC 
Here you go:
https://github.com/gallatin/nstat/pull/1
Comment 4 Alan Somers freebsd_committer freebsd_triage 2018-07-27 17:39:41 UTC 
Thanks for fixing this so quickly.  Could you also please MFH?  Otherwise the quarterly branch will start failing to build on head once I make the change to src.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-07-27 20:59:16 UTC 
A commit references this bug:

Author: swills
Date: Fri Jul 27 20:59:03 UTC 2018
New revision: 475462
URL: https://svnweb.freebsd.org/changeset/ports/475462

Log:
  MFH: r475392

  net-mgmt/nstat: don't assume timespecadd is undefined

  PR:		230058
  Submitted by:	asomers

  Approved by:	ports-secteam (implicit)

Changes:
_U  branches/2018Q3/
  branches/2018Q3/net-mgmt/nstat/files/
Comment 6 Steve Wills freebsd_committer freebsd_triage 2018-07-27 20:59:50 UTC 
Done