Created attachment 195622 [details] Makefile patch The supposed "fix" for luaexpat in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224644 is incorrect, and this is easily demonstrated by running the test.lua script included in the module source. The most reasonable fix seems to be this (in addition to removing the incorrect LUA_32BITS): MAKE_ARGS+= COMMON_CFLAGS="-Wall" (i.e. removing options -g -O2 -ansi -pedantic -fPIC -DPIC from the makefile; -fPIC is added back from CFLAGS already, and debug/optimization flags are likewise supposed to come from the port CFLAGS.) Another option that works would be to use -std=c99, but I think the above method is better (and I have checked that the test script runs ok on lua 5.1 and 5.2 still). Patch attached. (I also added a LICENSE=MIT - see the doc/us/license.html in the distribution)
(In reply to andrew from comment #0) oops, forgot to increment PORTREVISION should I post a new patch or is it not worth it?
No worries, I'll submit it with the portrevision bump.
A commit references this bug: Author: lx Date: Mon Jul 30 21:43:31 UTC 2018 New revision: 475915 URL: https://svnweb.freebsd.org/changeset/ports/475915 Log: Better fix for INT build failures. PR: 230179 Submitted by: andrew@tao11.riddles.org.uk Changes: head/textproc/luaexpat/Makefile
Committed, thanks!