Created attachment 195702 [details] Patch to update the rox-filer port to use libinotify. Trying to compile rox-filer ends in a failure: cc -o "ROX-Filer" abox.o action.o appinfo.o appmenu.o bind.o bookmarks.o bulk_rename.o cell_icon.o choices.o collection.o dir.o diritem.o display.o dnd.o dropbox.o filer.o find.o fscache.o gtksavebox.o gui_support.o i18n.o icon.o infobox.o log.o main.o menu.o minibuffer.o modechange.o mount.o options.o panel.o pinboard.o pixmaps.o remote.o run.o sc.o session.o support.o tasklist.o toolbar.o type.o usericons.o view_collection.o view_details.o view_iface.o wrapped.o xml.o xtypes.o xdgmime.o xdgmimeglob.o xdgmimeint.o xdgmimemagic.o xdgmimeparent.o xdgmimealias.o xdgmimecache.o -fstack-protector `pkgconf --libs gtk+-2.0 libxml-2.0 | sed 's/-lpangoxft-[^ ]*//'` -lintl -lm -L/usr/local/lib -lX11 -lICE -lSM dir.o: In function `dir_init': dir.c:(.text+0x2d): undefined reference to `inotify_init' dir.o: In function `dir_attach': dir.c:(.text+0x26d): undefined reference to `inotify_add_watch' cc: error: linker command failed with exit code 1 (use -v to see invocation) gmake[1]: *** [Makefile:48: ROX-Filer] Error 1 gmake[1]: Leaving directory '/usr/ports/x11-fm/rox-filer/work/rox-filer-2.11/ROX-Filer/src' ===> Compilation failed unexpectedly. To begin with I added -linotify to LIBS in ROX-Filer/src/Makefile.in. Additionally I added a LIB_DEPENDS on libinotify, and upped the portrevision. See enclosed patch.
By the way, make gives: /!\ rox-filer-2.11_5: Makefile warnings, please consider fixing /!\ Please set LICENSE for this port and make stage ends with: ====> Running Q/A tests (stage-qa) Error: /usr/local/apps/ROX-Filer/ROX-Filer is linked to /usr/local/lib/libcairo.so.2 from graphics/cairo but it is not declared as a dependency Warning: you need USE_GNOME+=cairo Error: /usr/local/apps/ROX-Filer/ROX-Filer is linked to /usr/local/lib/libgdk_pixbuf-2.0.so.0 from graphics/gdk-pixbuf2 but it is not declared as a dependency Warning: you need USE_GNOME+=gdkpixbuf2 Error: /usr/local/apps/ROX-Filer/ROX-Filer is linked to /usr/local/lib/libfontconfig.so.1 from x11-fonts/fontconfig but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libfontconfig.so:x11-fonts/fontconfig Error: /usr/local/apps/ROX-Filer/ROX-Filer is linked to /usr/local/lib/libfreetype.so.6 from print/freetype2 but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libfreetype.so:print/freetype2 Error: /usr/local/apps/ROX-Filer/ROX-Filer is linked to /usr/local/lib/libICE.so.6 from x11/libICE but it is not declared as a dependency Warning: you need USE_XORG+=ice I am on these.
Committed, thanks!
A commit references this bug: Author: pi Date: Thu Aug 16 08:37:29 UTC 2018 New revision: 477312 URL: https://svnweb.freebsd.org/changeset/ports/477312 Log: x11-fm/rox-filer: requires libinotify to build PR: 230250 Submitted by: rsmith@xs4all.nl Approved by: olgeni (maintainer timeout) Changes: head/x11-fm/rox-filer/Makefile head/x11-fm/rox-filer/files/patch-ROX-Filer_src_Makefile.in
I submitted an additional patch through Bug 230710.