Created attachment 195739 [details] Update Patch Changelog: https://cgit.freedesktop.org/libfprint/fprintd/tree/NEWS # portlint -AC looks fine.
Maintainer informed via mail
Created attachment 195740 [details] Poudriere Log
Created attachment 195741 [details] Update Patch Will add Poudriere log next
Created attachment 195742 [details] Poudriere Log
(In reply to Nathan from comment #3) -USES= tar:xz gmake libtool pkgconfig +USES= tar:xz gmake \ + libtool pkgconfig Nathan, thanks for all of your submissions, but please do not make changes like this. There is nothing wrong with the original version. You can maybe add a newline to USES when the line approaches 80 columns but it is not even close here. -etc/fprintd.conf +%%ETCDIR%%.conf This is bogus. Please revert it. %%ETCDIR%% is supposed to be a directory (as the name implies) not part of a filename. +share/locale/ar/LC_MESSAGES/fprintd.mo Where did %%NLS%% go? Did you do a test build with NLS=off? make makeplist is a big help in generating a plist but you still have to sanity check its output and not just accept it as is. This is doubly important when the port has options.
(In reply to Tobias Kortkamp from comment #5) > (In reply to Nathan from comment #3) > -USES= tar:xz gmake libtool pkgconfig > +USES= tar:xz gmake \ > + libtool pkgconfig > > Nathan, thanks for all of your submissions, but please do not make > changes like this. There is nothing wrong with the original version. > You can maybe add a newline to USES when the line approaches 80 > columns but it is not even close here. > > -etc/fprintd.conf > +%%ETCDIR%%.conf > > This is bogus. Please revert it. %%ETCDIR%% is supposed to be a > directory (as the name implies) not part of a filename. > > +share/locale/ar/LC_MESSAGES/fprintd.mo > > Where did %%NLS%% go? Did you do a test build with NLS=off? > > make makeplist is a big help in generating a plist but you still > have to sanity check its output and not just accept it as is. This > is doubly important when the port has options. Nope didn’t turn it off. Seems to be some bug somewhere. It shows in configure says nls is explicitly enabled. On the etc.conf issue I couldn’t find where make caused that
(In reply to Nathan from comment #6) > Nope didn’t turn it off. Seems to be some bug somewhere. > It shows in configure says nls is explicitly enabled If the NLS option doesn't do its job properly (in fprintd 0.6.0 it works correctly) we either need to fix it or remove it entirely if it's unfixable. Either way we shouldn't leave it in a half-broken state. Please readd the %%NLS%% prefixes to all share/locale entries in pkg-plist again as a first step. > On the etc.conf issue I couldn’t find where make caused that It's normal because there's a PLIST_SUB for ETCDIR imposed by the framework (which is defined to etc/${PORTNAME} in PLIST_SUB by default) and makeplist tries to substitute values to variables in pkg-plist based on PLIST_SUB. It sometimes gets things wrong and you need to manually correct it.
Contacting upstream. I still am not able to get NLS to work
Created attachment 196265 [details] Update
Updating to latest version:0.8.1 and see if it is fixed, should we reset maintainer?
Created attachment 196777 [details] Update; Avoid need of gtk-doc dep; security/fprintd: * Update to 0.8.1 * Remove need for gtk-doc -- Port doesn't install DOCS either way * Switched source to github -- Latest version hosted * Add gettext to uses -- Port will not install without it Changelog: https://github.com/freedesktop/libfprint-fprintd/blob/V_0_8_1/NEWS
Created attachment 196778 [details] Update; Avoid need of gtk-doc dep security/fprintd: * Update to 0.8.1 * Remove need for gtk-doc -- Port doesn't install DOCS either way * Switched source to github -- Latest version hosted * Add gettext to uses -- Port will not install without it Changelog: https://github.com/freedesktop/libfprint-fprintd/blob/V_0_8_1/NEWS
Created attachment 197412 [details] Update ; Remove gtk-doc dep security/fprintd: Update to 0.8.1 Add LICENSE file, while here Rearrange variables, to correct order Remove doc build, removes need of gtk-doc and doesn't build PR: 230279 Submitted by: Nathan <ndowens@yahoo.com>
A commit references this bug: Author: miwi Date: Fri Jan 11 15:02:44 UTC 2019 New revision: 489978 URL: https://svnweb.freebsd.org/changeset/ports/489978 Log: - Update to 0.8.1 - Add LICENSE file PR: 230279 Submitted by: ndowens@yahoo.com Approved by: maintainer timeout Sponsored by: iXsystems Inc. Changes: head/security/fprintd/Makefile head/security/fprintd/distinfo head/security/fprintd/files/ head/security/fprintd/pkg-plist