Bug 230356 - [PATCH] games/freeorion: fails to link with lld as system linker
Summary: [PATCH] games/freeorion: fails to link with lld as system linker
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guido Falsi
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-08-04 17:18 UTC by Guido Falsi
Modified: 2018-08-29 18:46 UTC (History)
1 user (show)

See Also:
amdmi3: maintainer-feedback+

Attachments
patch adding LLD_UNSAFE (291 bytes, patch)
2018-08-04 17:18 UTC, Guido Falsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2018-08-04 17:18:42 UTC 
Created attachment 195850 [details]
patch adding LLD_UNSAFE

On head, where lld is the default compiler freeorion fails with the following error (trimmed):

/usr/bin/ld: error: cannot preempt symbol: alcGetCurrentContext
>>> defined in /usr/local/lib/libopenal.so
>>> referenced by Sound.cpp
>>>               CMakeFiles/freeorion.dir/UI/Sound.cpp.o:(Sound::Impl::Disable())

/usr/bin/ld: error: cannot preempt symbol: alSourceStop
>>> defined in /usr/local/lib/libopenal.so
>>> referenced by Sound.cpp
>>>               CMakeFiles/freeorion.dir/UI/Sound.cpp.o:(Sound::Impl::Disable())

/usr/bin/ld: error: cannot preempt symbol: alSourcei
>>> defined in /usr/local/lib/libopenal.so
>>> referenced by Sound.cpp
>>>               CMakeFiles/freeorion.dir/UI/Sound.cpp.o:(Sound::Impl::Disable())

[...]

Attached patch marks it as unsafe with LLD, forcing usage of old ld for this port. This allows it to link correctly.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2018-08-28 15:39:48 UTC 
Feel free to commit as long as it fixes the problem. It even falls under the blanket IMO.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-08-29 18:46:13 UTC 
A commit references this bug:

Author: madpilot
Date: Wed Aug 29 18:45:45 UTC 2018
New revision: 478365
URL: https://svnweb.freebsd.org/changeset/ports/478365

Log:
  Mark as LLD_UNSAFE.

  PR:		230356
  Submitted by:	me
  Approved by:	amdmi3 (maintainer)

Changes:
  head/games/freeorion/Makefile
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2018-08-29 18:46:51 UTC 
Committed.

Thanks!