Bug 230537 - [NEW PORT] emulators/emulationstation: Cross-platform graphical front-end for emulators (RetroPie fork)
Summary: [NEW PORT] emulators/emulationstation: Cross-platform graphical front-end for...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-11 15:55 UTC by freebsd
Modified: 2019-01-27 05:55 UTC (History)
1 user (show)

See Also:


Attachments
emulators/emulationstation: initial port (v2.7.1) (11.08 KB, patch)
2018-08-11 15:55 UTC, freebsd
freebsd: maintainer-approval+
Details | Diff
emulators/emulationstation: Rev 1 (v2.7.1) (11.40 KB, patch)
2019-01-26 16:40 UTC, freebsd
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2018-08-11 15:55:49 UTC
Created attachment 196090 [details]
emulators/emulationstation: initial port (v2.7.1)

EmulationStation is a cross-platform graphical front-end for emulators, with controller-based navigation. The original project[1] has not seen updates since 2015. However, it is the frontend used by the popular RetroPi project; this is an actively-maintaned fork[2] from RetroPie.

* New port, release v2.7.1.
  - Includes patches to fix compiler errors on FreeBSD due to missing includes of <string>
  - Includes patch to use POSIX sleep function instead of Windows sleep function
  - Includes patch to use pugixml from ports tree, rather than embedded.

portlint -AC: OK (looks fine.)
testport: OK (poudriere: 11.2-amd64)

[1] https://github.com/Aloshi/EmulationStation/
[2] https://github.com/RetroPie/EmulationStation/
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-21 11:35:11 UTC
Hi,

let's break the 6 months or so of silence.  Are you still interested in
getting this into the ports tree?

Overall this looks ok, but there are a couple of problems that would
be good to fix.

Can you install some documentation like README.md, SYSTEMS.md, ... too? 

+LICENSE=	UNKNOWN APACHE20
+LICENSE_COMB=	multi
+LICENSE_NAME_UNKNOWN=	unknown
+LICENSE_FILE_UNKNOWN=	${WRKSRC}/LICENSE.md
+LICENSE_PERMS_UNKNOWN=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept

UNKNOWN seems to be the well-known MIT license.

+		libSDL2.so:devel/sdl20\

Please use

USE_SDL=	sdl2

for this.

+USES+=		cmake compiler:gcc-c++11-lib pkgconfig

+= is not necessary here.  Just use =.

Why compiler:gcc-c++11-lib?  What's the problem with compiling it
with Clang?  Do you think this might be fixable?

+GH_TAGNAME=	b833b45

This matches the upstream tag v2.7.1, so please remove this and
just set

DISTVERSIONPREFIX=	v

+USE_GL+=	gl glu

Again += is not necessary here. Use =

+WWW: https://emulationstation.org (original)
+     https://github.com/RetroPie/EmulationStation (RetroPi Fork)

WWW must be a single line with just a URL.  I'd say go with the
second URL since this is what you package here.
Comment 2 freebsd 2019-01-26 16:40:58 UTC
Created attachment 201415 [details]
emulators/emulationstation: Rev 1 (v2.7.1)

Tobias,

This patch should address the concerns noted. 

Re: use of "compiler:gcc-c++11-lib", yes there was trouble getting the port to build with Clang. It's obviously been a while since I did this, but I recall trying Clang first, and eventually giving up and using gcc.
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-27 05:55:12 UTC
Committed with some minor changes.  Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-01-27 05:55:53 UTC
A commit references this bug:

Author: tobik
Date: Sun Jan 27 05:55:08 UTC 2019
New revision: 491326
URL: https://svnweb.freebsd.org/changeset/ports/491326

Log:
  New port: emulators/emulationstation

  EmulationStation is a cross-platform graphical front-end for
  emulators, with controller navigation.

  Originally written by Alec "Aloshi" Lofquist, this is a fork by
  RetroPie.

  WWW: https://github.com/RetroPie/EmulationStation

  PR:		230537
  Submitted by:	freebsd@coombscloud.com

Changes:
  head/emulators/Makefile
  head/emulators/emulationstation/
  head/emulators/emulationstation/Makefile
  head/emulators/emulationstation/distinfo
  head/emulators/emulationstation/files/
  head/emulators/emulationstation/files/patch-es-app_src_FileFilterIndex.h
  head/emulators/emulationstation/files/patch-es-app_src_MetaData.h
  head/emulators/emulationstation/files/patch-es-app_src_ScraperCmdLine.cpp
  head/emulators/emulationstation/files/patch-es-core_src_InputConfig.h
  head/emulators/emulationstation/files/patch-es-core_src_PowerSaver.cpp
  head/emulators/emulationstation/files/patch-es-core_src_Settings.cpp
  head/emulators/emulationstation/files/patch-es-core_src_Sound.h
  head/emulators/emulationstation/files/patch-es-core_src_ThemeData.h
  head/emulators/emulationstation/files/patch-external_CMakeLists.txt
  head/emulators/emulationstation/pkg-descr