Created attachment 196092 [details] Update textproc/libunibreak: Update to 4.0 * Changed source to Github -- Latest versions are hosted there * Added patch-src_Makefile -- Fixes Error: Bad symlink 'lib/liblinebreak.a' pointing inside the stage directory Changelog: https://github.com/adah1972/libunibreak/blob/23aa7415254420de0aa4186e72f602257762c9ec/NEWS Built using Poudriere 3.2.7 11.2-Release AMD64 Portlint -AC: looks fine
Also, fixes fbreader; with previous version, fbrunner would not launch
Created attachment 196093 [details] Update
Created attachment 196106 [details] Update; Removed patches
Using USE_GITHUB is wrong here. Please use the static tarball from https://github.com/adah1972/libunibreak/releases/download/libunibreak_4_0/libunibreak-4.0.tar.gz It contains pregenerated files like a configure script and you can drop USES=autoreconf again.
(In reply to Tobias Kortkamp from comment #4) Why the preference for not running autoreconf? Performance?
Either way I have the patch without autoreconf ready but I’m on my phone so can’t upload it. I ssh to my home pc while I’m away to do ports stuff
(In reply to Steve Wills from comment #5) It's not about not using USES=autoreconf. USE_GITHUB implies use of codeload.github.com which generates volatile tarballs that are not guaranteed to be stable i.e. they can change checksums. A nice discussion about this can be found here: https://github.com/libgit2/libgit2/issues/4343 Besides when upstream releases tarballs they might not be identical to a tarball generated via codeload.github.com. Often they contain pregenerated scripts/manpages/files that we would have to generate ourselves. This alone should be reason enough to prefer them over the USE_GITHUB ones when upstream takes the time to prepare them. Stuart Henderson from OpenBSD has explained the situation very well too IMHO (ignore the OpenBSD specific bits): https://marc.info/?l=openbsd-ports&m=151973450514279&w=2
(In reply to Tobias Kortkamp from comment #7) Ok, sounds fine to me to fetch the release tarball instead of the generated one, but would prefer to keep USES=autoreconf and patch src/Makefile.am as that seems cleaner to me.
Problem to me is there needs to be a standard. One can do it this way but submit a different port and reviewer will say to use USE_GITHUB
(In reply to Nathan from comment #9) I think for right now and this PR we should just focus on this port.
(In reply to Steve Wills from comment #8) Fine with me. Though I bet LN_S could also be overwritten via MAKE_ARGS MAKE_ARGS= LN_S="${INSTALL_DATA}"
Created attachment 196261 [details] Updated patch based on discussion This look OK then?
(In reply to Steve Wills from comment #12) > Created attachment 196261 [details] > Updated patch based on discussion > > This look OK then? Yup :)
(In reply to Steve Wills from comment #12) Looks ok. Since there are no build file patches anymore, USES=autoreconf is not really needed now, but it's fine with me either way.
A commit references this bug: Author: swills Date: Fri Aug 17 12:37:02 UTC 2018 New revision: 477422 URL: https://svnweb.freebsd.org/changeset/ports/477422 Log: textproc/libunibreak: Update to 4.0 While here, assign maintainer PR: 230539 (with modifications) Submitted by: Nathan <ndowens@yahoo.com> Changes: head/textproc/libunibreak/Makefile head/textproc/libunibreak/distinfo head/textproc/libunibreak/files/ head/textproc/libunibreak/pkg-plist
Committed, thanks!