Bug 230599 - [patch] security/theonionbox: Add missing run dependency
Summary: [patch] security/theonionbox: Add missing run dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-13 19:35 UTC by Carsten Larsen
Modified: 2018-08-14 01:10 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
diff (768 bytes, patch)
2018-08-13 19:35 UTC, Carsten Larsen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Larsen 2018-08-13 19:35:20 UTC 
Created attachment 196168 [details]
diff

Fix: Add databases/py-sqlite3 as run dependency

poudriere 11.2: No errors
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-13 19:42:18 UTC 
Carsten, thank you for the patch.

Yuri
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-13 19:55:49 UTC 
sqlite3 is in the pythin base distribution since 2.5: https://docs.python.org/2/library/sqlite3.html

Did you get some error because it was missing?
Comment 3 Carsten Larsen 2018-08-13 20:07:35 UTC 
(In reply to Yuri Victorovich from comment #2)

I was also wandering about the error. Without databases/py-sqlite3 installed:

Traceback (most recent call last):
  File "/usr/local/bin/theonionbox", line 11, in <module>
    load_entry_point('theonionbox==4.2.1', 'console_scripts', 'theonionbox')()
  File "/usr/local/lib/python2.7/site-packages/theonionbox/__main__.py", line 18, in main
    from .theonionbox import main as onion_main
  File "/usr/local/lib/python2.7/site-packages/theonionbox/theonionbox.py", line 1031, in <module>
    from tob.persistor import Storage
  File "/usr/local/lib/python2.7/site-packages/theonionbox/tob/persistor.py", line 2, in <module>
    import sqlite3
  File "/usr/local/lib/python2.7/sqlite3/__init__.py", line 24, in <module>
    from dbapi2 import *
  File "/usr/local/lib/python2.7/sqlite3/dbapi2.py", line 28, in <module>
    from _sqlite3 import *
ImportError: No module named _sqlite3

Running Python version is 2.7.15
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-13 20:17:43 UTC 
This looks like a bug in the python-2.7 port.

You can test the same with python-3.4 if you replace python->python:3.4+ and truncate the README file after configure.
Comment 5 Carsten Larsen 2018-08-13 21:00:23 UTC 
(In reply to Yuri Victorovich from comment #4)

I'm currently running the port in a jail, managed by ezjail with a shared ports tree. I need another setup before I can do the test.
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-14 01:09:52 UTC 
Committed, thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-08-14 01:10:22 UTC 
A commit references this bug:

Author: yuri
Date: Tue Aug 14 01:09:34 UTC 2018
New revision: 477126
URL: https://svnweb.freebsd.org/changeset/ports/477126

Log:
  security/theonionbox: Add sqlite3 dependency; Backport fixes that the upstream made.

  Port changes:
  * sqlite3 dependency is need as a workaround for bug#230613
  * Backport the fix of the problem of python3 compatibility
  * Backport the fix of python2 build error
  * Backport the fix of windows newline in the shell script
  * Backport the Onionoo protocol version mismatch fix

  PR:		230599
  Submitted by:	Carsten Larsen <cs@innolan.net> (sqlite3 part)

Changes:
  head/security/theonionbox/Makefile
  head/security/theonionbox/distinfo