Bug 230695 - games/monster-masher: Remove esound dependency
Summary: games/monster-masher: Remove esound dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-08-17 13:07 UTC by Tobias Kortkamp
Modified: 2018-08-31 08:46 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (kwm)

Attachments
monster-masher.diff (1.98 KB, patch)
2018-08-17 13:07 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (kwm)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-17 13:07:31 UTC 
Created attachment 196281 [details]
monster-masher.diff

In recent versions of x11/libgnome, gnome_sound_connection_get()
always returns -1 [1], so calling esd_sample_play() can never work.

Can we remove the esound dependency?

[1] https://developer.gnome.org/libgnome/stable/libgnome-gnome-sound.html#gnome-sound-connection-get
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-08-31 08:46:16 UTC 
A commit references this bug:

Author: tobik
Date: Fri Aug 31 08:46:11 UTC 2018
New revision: 478530
URL: https://svnweb.freebsd.org/changeset/ports/478530

Log:
  games/monster-masher: Remove esound dependency

  Since libgnome 2.30 gnome_sound_connection_get() always returns -1 [1],
  so calling esd_sample_play() can never work.

  [1] https://developer.gnome.org/libgnome/stable/libgnome-gnome-sound.html#gnome-sound-connection-get

  PR:		230695
  Submitted by:	tobik
  Approved by:	kwm (maintainer timeout, 2 weeks)

Changes:
  head/games/monster-masher/Makefile
  head/games/monster-masher/files/patch-src_sound.cpp