Bug 230869 - emulators/quasi88 failed to build
Summary: emulators/quasi88 failed to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-24 20:06 UTC by Mamoru IWAKI
Modified: 2018-08-25 01:25 UTC (History)
0 users

See Also:

Attachments
a patch as workaround (347 bytes, patch)
2018-08-24 20:06 UTC, Mamoru IWAKI 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mamoru IWAKI 2018-08-24 20:06:11 UTC 
Created attachment 196506 [details]
a patch as workaround

Hi,

I encountered build failure on the following port,
 
   # $FreeBSD: head/emulators/quasi88/Makefile 409868 2016-03-01 11:12:14Z madpilot $

I tried it on the following environment,

   FreeBSD 11.2-STABLE #1 r338182: Wed Aug 22 15:15:04 JST 2018 amd64

New compiler maybe more strict than ever.
I attached a patch as workaround.
Please check it out.

Cheers
---
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-25 01:25:02 UTC 
Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-08-25 01:25:05 UTC 
A commit references this bug:

Author: tobik
Date: Sat Aug 25 01:24:41 UTC 2018
New revision: 477989
URL: https://svnweb.freebsd.org/changeset/ports/477989

Log:
  emulators/quasi88: Fix build with Clang 6

  src/fmgen/psg.cpp:121:37: error: constant expression evaluates to -1 which cannot be narrowed to type 'uint8' (aka 'unsigned char') [-Wc++11-narrowing]
          static uint8 table3[4] = {  0,  1, -1,  0 };
                                             ^~

  http://beefy11.nyi.freebsd.org/data/head-i386-default/p477468_s337991/logs/quasi88-0.6.4.log

  PR:		230869
  Submitted by:	1wkmmr@gmail.com

Changes:
  head/emulators/quasi88/files/
  head/emulators/quasi88/files/patch-src_fmgen_psg.cpp