Bug 230880 - astro/wmsolar: Fix build with Clang 6
Summary: astro/wmsolar: Fix build with Clang 6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: http://beefy11.nyi.freebsd.org/data/h...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-25 02:36 UTC by Tobias Kortkamp
Modified: 2018-09-09 07:05 UTC (History)
0 users

See Also:

Attachments
astro__wmsolar.diff (1.63 KB, patch)
2018-08-25 02:36 UTC, Tobias Kortkamp 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-25 02:36:35 UTC 
The build fails with Clang 6 and soon the port will be marked as
BROKEN on 12.0 and 11.2 if we do not act.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-25 02:36:55 UTC 
Created attachment 196516 [details]
astro__wmsolar.diff
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-09-09 07:05:00 UTC 
A commit references this bug:

Author: tobik
Date: Sun Sep  9 07:04:54 UTC 2018
New revision: 479272
URL: https://svnweb.freebsd.org/changeset/ports/479272

Log:
  astro/wmsolar: Fix build with Clang 6

  In file included from wmSolar.c:15:
  ./wmSolar_mask.xbm:6:12: error: constant expression evaluates to 240 which cannot be narrowed to type 'char' [-Wc++11-narrowing]
   0x00,0x00,0xf0,0xff,0xff,0xff,0xff,0xff,0xff,0x0f,0xf0,0xff,0xff,0xff,0xff,
             ^~~~

  http://beefy12.nyi.freebsd.org/data/head-amd64-default/p479076_s338486/logs/errors/wmsolar-1.1.log

  In file included from wmSolar.c:18:
  ./Lunar.h:66:23: error: in-class initializer for static data member of type
        'const double' requires 'constexpr' specifier [-Wstatic-float-init]
    static const double SYNODIC_MONTH = 29.530588861;
                        ^

  PR:		230880
  Approved by:	tkuiper@inxsoft.net (maintainer timeout, 2 weeks)

Changes:
  head/astro/wmsolar/Makefile