Bug 230881 - biology/seaview: Fix build with Clang 6
Summary: biology/seaview: Fix build with Clang 6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: http://beefy11.nyi.freebsd.org/data/h...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-25 03:53 UTC by Tobias Kortkamp
Modified: 2018-09-08 09:02 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bofh)

Attachments
biology__seaview.diff (4.61 KB, patch)
2018-08-25 03:53 UTC, Tobias Kortkamp 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-25 03:53:16 UTC 
The build fails with Clang 6 and soon the port will be marked as
BROKEN on 12.0 and 11.2 if we do not act.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-25 03:53:40 UTC 
Created attachment 196518 [details]
biology__seaview.diff
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-09-08 09:02:33 UTC 
A commit references this bug:

Author: tobik
Date: Sat Sep  8 09:01:36 UTC 2018
New revision: 479235
URL: https://svnweb.freebsd.org/changeset/ports/479235

Log:
  biology/seaview: Fix build with Clang 6

  seaview.cxx:3352:24: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
                  strcat(suggested, "."PDF_OR_PS_EXT);
                                       ^

  http://beefy12.nyi.freebsd.org/data/head-amd64-default/p479076_s338486/logs/errors/seaview-4.7,1.log

  PR:		230881
  Submitted by:	tobik
  Approved by:	bofh (maintainer timeout, 2 weeks)

Changes:
  head/biology/seaview/files/
  head/biology/seaview/files/patch-seaview.cxx
  head/biology/seaview/files/patch-treedraw.cxx
  head/biology/seaview/files/patch-xfmatpt.cxx