Bug 230965 - net/remmina-plugins: r478203 breaks portscout
Summary: net/remmina-plugins: r478203 breaks portscout
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ben Woods
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-08-27 22:52 UTC by Dmitri Goutnik
Modified: 2018-08-28 09:37 UTC (History)
1 user (show)

See Also:
woodsb02: maintainer-feedback+

Attachments
patch file (592 bytes, patch)
2018-08-27 22:52 UTC, Dmitri Goutnik 		woodsb02: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2018-08-27 22:52:17 UTC 
Created attachment 196621 [details]
patch file

After r478203:

$ make -C /usr/ports/net/remmina-plugins -V MASTER_SITES
 https://gitlab.com/Remmina/Remmina/repository/65d552c9becc957cae124ab5c26562cf22c052b9/archive.tar.gz?dummy=/

That leading space character in MASTER_SITES breaks "portscout rebuild":

Can't locate object method "host" via package "URI::_generic" at /usr/local/lib/perl5/site_perl/Portscout/DataSrc/Ports.pm line 460
Comment 1 Ben Woods freebsd_committer freebsd_triage 2018-08-27 23:53:01 UTC 
Comment on attachment 196621 [details]
patch file

Looks good, thanks for finding the fix.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-08-28 09:36:58 UTC 
A commit references this bug:

Author: woodsb02
Date: Tue Aug 28 09:36:55 UTC 2018
New revision: 478294
URL: https://svnweb.freebsd.org/changeset/ports/478294

Log:
  net/remmina-plugins: Fix portscout

  Before this change, the output of "make -V MASTER_SITES" would start
  with a leading space character, which would break portscout.

  PR:		230965
  Submitted by:	Dmitri Goutnik <dg@syrec.org>

Changes:
  head/net/remmina-plugins/Makefile
Comment 3 Ben Woods freebsd_committer freebsd_triage 2018-08-28 09:37:46 UTC 
Committed, thanks!