Created attachment 196712 [details] [PATCH] sysutils/shim: update to 0.9 I'd also like to adopt the port, and changed the MAINTAINER info.
Take
Hi Vinicius, Thanks for the submission and for volunteering to maintain the port :-) There are a number of issues with the current state of the Makefile. This is what you get if you run portlint -AC: WARN: Makefile: [17]: USE_* seen before USES. According to the porters-handbook, USES must appear first. WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier. WARN: /usr/home/fernape/FreeBSD-repos/ports/head/sysutils/shim/files/patch-Cryptlib-Makefile: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. WARN: /usr/home/fernape/FreeBSD-repos/ports/head/sysutils/shim/files/patch-Cryptlib-OpenSSL-Makefile: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. WARN: /usr/home/fernape/FreeBSD-repos/ports/head/sysutils/shim/files/patch-elf_x86_64_efi.lds: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. WARN: /usr/home/fernape/FreeBSD-repos/ports/head/sysutils/shim/files/patch-lib-Makefile: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. WARN: /usr/home/fernape/FreeBSD-repos/ports/head/sysutils/shim/files/patch-Makefile: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. Would you have a look at them? A couple of items need to be located in its proper place. The other warnings refer to the patches that are hand made. This ones can be corrected by running make patch && make makepatch.
(In reply to Fernando ApesteguÃa from comment #2) Hi Fernando, sorry for the late reply! I'm gonna have a look and write back with an updated version for this patch. KR,
Created attachment 196895 [details] [PATCH] sysutils/shim: update to 0.9, reviewed New version of the patch available here. Thanks for taking time looking into it! Appreciated.
(In reply to Vinícius Zavam from comment #4) Hi again! Thanks for the update. I have a slightly different version of the patch using shebangfix instead of doing the post-patch target. Also there is an ongoing discussion about why this port is amd64 only. You can have a look (and participate if you like) at: https://reviews.freebsd.org/D17019 Thanks :)
(In reply to Fernando ApesteguÃa from comment #5) Awesome stuff, Fernando. Nice one using the 'shebangfix'. I just noticed one little thing: -ONLY_FOR_ARCHS_REASON= depends on devel/gnu-efi that is 32 bit only +ONLY_FOR_ARCHS_REASON= depends on devel/gnu-efi that is amd64-only Sadly, I can't login to Phabricator right now; private reasons.
(In reply to Vinícius Zavam from comment #6) Nice catch. Corrected :)
Thanks! I did not see if we still have any other issues; looks good to me. Many thanks for all your help on this one. Appreciated!
Hi Fernando, how are things? :) I am adding my mentors here in CC, so we can work together if you need anything else from my side. Ok? KR,
(In reply to VinÃcius Zavam from comment #9) Sorry for my late reply, just got back from holidays :) I replied in the review that this one builds in amd64 and fails in i386 due to a dependency. I can not provide run testing for this one. If you want to take over this PR, please do it ;) I can help in other things should you need it :)
(In reply to Fernando ApesteguÃa from comment #10) sweet! than you Fernando, I will take this one tou. I would also say we could proceed with a commit, as we followed not many changes on the main port and also applied recommendations from our mentors and mat@ mentors: OK?
A commit references this bug: Author: egypcio Date: Wed Nov 21 13:27:08 UTC 2018 New revision: 485512 URL: https://svnweb.freebsd.org/changeset/ports/485512 Log: sysutils/shim: update from 0.8 to 0.9 - adopt the port; - original version from PR 231029 was modified; - add compiler, and shebangfix to USES; - reorder variables in Makefile (silent portlint); - rework do-install. PR: 231029 Reviewed by: fernape, mat, tcberner, trasz Approved by: rene (mentor) Differential Revision: https://reviews.freebsd.org/D17019 Changes: head/sysutils/shim/Makefile head/sysutils/shim/distinfo head/sysutils/shim/files/patch-Cryptlib-Makefile head/sysutils/shim/files/patch-Cryptlib-OpenSSL-Makefile head/sysutils/shim/files/patch-Makefile head/sysutils/shim/files/patch-elf_x86_64_efi.lds head/sysutils/shim/files/patch-lib-Makefile