Bug 231184 - editors/teco: provide detailed manual page and claim maintainership
Summary: editors/teco: provide detailed manual page and claim maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-05 19:22 UTC by Bob Eager
Modified: 2018-09-28 17:49 UTC (History)
1 user (show)

See Also:


Attachments
Patches for files in port directory. (22.60 KB, patch)
2018-09-05 19:22 UTC, Bob Eager
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Eager 2018-09-05 19:22:48 UTC
Created attachment 196894 [details]
Patches for files in port directory.

I would like to claim maintainership of this port.

I am providing a detailed manual page, written by me. There is also a short README.bsd file.

I have re-made the patch files to use the canonical naming, so all of the files in files/patch* are in fact new.

Overall port patch file attached.

New files:
files/teco.1.in
files/README.bsd.in
files/patch*

Deleted files:
files/patch-makefile
files/patch-zlinux

The port passes portlint -C and port test. Tested on i386 and amd64, 11-2-STABLE (337580).
Comment 1 Bob Eager 2018-09-05 19:24:03 UTC
Before panicking, note that most of the patch is in fact the new manual page!
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2018-09-06 18:18:35 UTC
Hi Bob,

Thanks for the submission. Do you mean editors/teco? I don't have any textproc/teco in a very updated svn copy of the ports tree.
Comment 3 Bob Eager 2018-09-06 20:49:28 UTC
My apologies, yes it should be editors/teco.

The last thing I worked on was in textproc, and I obviously failed to clear my brain cache!
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2018-09-06 21:23:45 UTC
(In reply to bob from comment #3)
No problem :)
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-09-28 17:47:46 UTC
A commit references this bug:

Author: fernape
Date: Fri Sep 28 17:47:41 UTC 2018
New revision: 480869
URL: https://svnweb.freebsd.org/changeset/ports/480869

Log:
  editors/teco: Improve documentation and set maintainership

  * Add detailed man page
  * Add DOCS option
  * Add LICENSE
  * Give maintainership to submitter

  PR:	231184
  Submitted by:	bob@eager.cx
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D17228

Changes:
  head/editors/teco/Makefile
  head/editors/teco/files/patch-makefile
  head/editors/teco/files/patch-src_makefile
  head/editors/teco/files/patch-src_skpcmd.c
  head/editors/teco/files/patch-src_zlinux.c
  head/editors/teco/files/patch-zlinux
  head/editors/teco/files/teco.1.in
  head/editors/teco/pkg-descr
  head/editors/teco/pkg-message
  head/editors/teco/pkg-plist
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2018-09-28 17:49:41 UTC
Committed, the maintainership is yours :-)

Thanks!

Please, note that we considered it was better to add the contents of README in pkg-message instead of adding the file itself.