Bug 231399 - [patch] x11-toolkits/wxgtk30: fix dependencies, add NOTIFY option, address portlint error
Summary: [patch] x11-toolkits/wxgtk30: fix dependencies, add NOTIFY option, address po...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-09-16 13:16 UTC by Andriy Voskoboinyk
Modified: 2019-01-28 07:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (portmaster)

Attachments
Makefile.diff (1.24 KB, patch)
2018-09-16 13:16 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Portlint -AC output (1.11 KB, text/plain)
2018-09-16 13:18 UTC, Andriy Voskoboinyk 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2018-09-16 13:16:44 UTC 
Created attachment 197142 [details]
Makefile.diff

- Add USES+=gnome, gl (requested by bsd.port.mk with DEVELOPER=yes in /etc/make.conf)
- Add NOTIFY option for notifications support via libnotify; without this change it's autodetected and automatically picked up if present (without dependency record)
- Append libGL / cairo / gdk-pixbuf2 port dependencies (libGL is needed by libGLU and cairo / gdk-pixbuf2 - by gtk20, so there will be no visible change).
- Move DISTVERSIONPREFIX before PORTREVISION as suggested by portlint(1).
- Bump PORTREVISION due to dependencies / options change.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2018-09-16 13:18:24 UTC 
Created attachment 197143 [details]
Portlint -AC output
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-01-28 07:06:26 UTC 
A commit references this bug:

Author: tobik
Date: Mon Jan 28 07:06:07 UTC 2019
New revision: 491458
URL: https://svnweb.freebsd.org/changeset/ports/491458

Log:
  x11-toolkits/wxgtk30: Add NOTIFY option

  Without this libnotify might be autodetected and automatically
  picked up if present in the build environment.

  - Add some missing dependencies
  - Pet portlint
  - Reset maintainer after the long timeout

  PR:		231399
  Submitted by:	avos
  Approved by:	portmaster@bsdforge.com (maintainer timeout, ~4 months)

Changes:
  head/x11-toolkits/wxgtk30/Makefile