Bug 231473 - [NEW PORT] databases/opendbviewer: OpenDBViewer is a simple database explorer
Summary: [NEW PORT] databases/opendbviewer: OpenDBViewer is a simple database explorer
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://github.com/Jet1oeil/opendbviewer
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2018-09-19 11:28 UTC by Loïc Bartoletti
Modified: 2018-09-20 11:23 UTC (History)
1 user (show)

See Also:
lbartoletti: maintainer-feedback+

Attachments
opendbviewer (4.92 KB, patch)
2018-09-19 11:28 UTC, Loïc Bartoletti 		lbartoletti: maintainer-approval+
Details | Diff
opendbviewer fix (4.93 KB, patch)
2018-09-20 06:02 UTC, Loïc Bartoletti 		lbartoletti: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Loïc Bartoletti freebsd_committer freebsd_triage 2018-09-19 11:28:58 UTC 
Created attachment 197228 [details]
opendbviewer

OpenDBViewer is a simple database explorer for SQLite, MySQL and PostgreSQL 
databases. It contains:

- SQL syntax highlightings
- Multi database, table and worksheet view
- Big database loading
- Open SQLite table directly with drag'n drop
- History of last connection
- Edit database directly from the table view

---
Only QT5 is proposed
Options : PGSQL (Default) and MYSQL
Comment 1 Loïc Bartoletti freebsd_committer freebsd_triage 2018-09-19 11:29:59 UTC 
Poudriere 11/12 i386/amd64 OK
portlint -Nabct OK

Tested @works
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2018-09-19 13:15:36 UTC 
Comment on attachment 197228 [details]
opendbviewer

+USE_QT=	buildtools core gui linguisttools network qmake \
+		sql sql-sqlite3 testlib widgets

Are buildtools, linguisttools, and qmake really needed at runtime
or are they just build dependencies?  Did you mean buildtools_build,
linguisttools_build, qmake_build instead?

+PGSQL_USE_QT+=	sql-pgsql
+MYSQL_USE_QT+=	sql-mysql

There is no _USE_QT options helper, so this has no effect.  Use the
regular _USE options helper instead:

MYSQL_USE=	QT=sql-mysql
PGSQL_USE=	QT=sql-pgsql
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2018-09-19 13:18:05 UTC 
Comment on attachment 197228 [details]
opendbviewer

+%%DATADIR%%/doc/ChangeLog
+%%DATADIR%%/doc/README

Any chance to install the docs into DOCSDIR?
Comment 4 Nathan 2018-09-19 16:57:13 UTC 
Tested on 12-386 and 11.2-386 for linker issues and there is no issue there
Comment 5 Loïc Bartoletti freebsd_committer freebsd_triage 2018-09-20 06:02:40 UTC 
Created attachment 197260 [details]
opendbviewer fix
Comment 6 Loïc Bartoletti freebsd_committer freebsd_triage 2018-09-20 06:03:12 UTC 
(In reply to Tobias Kortkamp from comment #3)
Done. Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-09-20 11:20:08 UTC 
A commit references this bug:

Author: tobik
Date: Thu Sep 20 11:19:14 UTC 2018
New revision: 480165
URL: https://svnweb.freebsd.org/changeset/ports/480165

Log:
  New port: databases/opendbviewer

  OpenDBViewer is a simple database explorer for SQLite, MySQL, and
  PostgreSQL databases.  It contains:

  - SQL syntax highlightings
  - Multi database, table, and worksheet view
  - Big database loading
  - Open SQLite table directly with drag'n drop
  - History of last connection
  - Edit database directly from the table view

  WWW: https://github.com/Jet1oeil/opendbviewer

  PR:		231473
  Submitted by:	lbartoletti@tuxfamily.org (based on)

Changes:
  head/databases/Makefile
  head/databases/opendbviewer/
  head/databases/opendbviewer/Makefile
  head/databases/opendbviewer/distinfo
  head/databases/opendbviewer/files/
  head/databases/opendbviewer/files/patch-CMakeLists.txt
  head/databases/opendbviewer/pkg-descr
  head/databases/opendbviewer/pkg-plist
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2018-09-20 11:23:46 UTC 
(In reply to lbartoletti from comment #6)
How have you (re-)tested this?

a) It doesn't pass check-plist now.  Probably a patch is missing
   for the DOCSDIR change?  README, ChangeLog don't just magically
   appear in DOCSDIR (share/doc/opendbviewer) over ${DATADIR}/doc
   (share/opendbviewer/doc) because the plist was updated.

b) +PGSQL_USE=	QT=	sql-pgsql

   Why add the extra tab after QT=?  It still has no effect
   like this.  This is easily testable via `make -V USE_QT`
   or `make run-depends-list`.

Anyway, committed with the necessary changes.