Bug 231475 - /net/haproxy update port to include kqueue fix
Summary: /net/haproxy update port to include kqueue fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-19 12:22 UTC by David King
Modified: 2018-09-20 12:46 UTC (History)
2 users (show)

See Also:
ndowens04: maintainer-feedback? (demon)

Attachments
ev_kqueue.c patch (1.02 KB, patch)
2018-09-19 12:23 UTC, David King 		no flags Details | Diff
update to 1.18.14 (4.69 KB, text/plain)
2018-09-20 12:31 UTC, David King 		no flags Details
upgrade to 1.8.14 (4.69 KB, patch)
2018-09-20 12:40 UTC, David King 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David King 2018-09-19 12:22:10 UTC 
The current version of haproxy (1.8.13) had a bug which meant it sometimes hung when using kqueue polling

https://www.mail-archive.com/haproxy@formilux.org/msg31190.html
http://git.haproxy.org/?p=haproxy-1.8.git;a=commit;h=8e5b0923a604685e5483cb28a51de3fb261929bb

This fix has now been backported to 1.8.13, so we need to create the patch file for this
Comment 1 David King 2018-09-19 12:23:08 UTC 
Created attachment 197229 [details]
ev_kqueue.c patch
Comment 2 Dmitry Sivachenko freebsd_committer freebsd_triage 2018-09-19 13:17:24 UTC 
Is that fix already in haproxy-1.8 branch?
If so, I'd rather wait until tomorrow (1.8.14 is expected tomorrow) and update the port so we do not do the same thing twice.

What do you think?
Comment 3 Nathan 2018-09-19 13:20:54 UTC 
(In reply to Dmitry Sivachenko from comment #2)
By the way it looks, it's in upstream's master source currently
Comment 4 Nathan 2018-09-19 13:21:50 UTC 
(In reply to Dmitry Sivachenko from comment #2)
I'm with you, especially if it is released tomorrow, then we should wait. No need to fix and update, when it can be done in one step.
Comment 5 David King 2018-09-19 13:23:25 UTC 
Hi,

Yes this is already fixed in master and the 1.8 branch

I didn't know 1.8.14 was out tomorrow, happy to wait till thats available, shall we keep the ticket open till then?

Where is the release schedule for haproxy as i couldn't see it anyway

Thanks!

Dave
Comment 6 Dmitry Sivachenko freebsd_committer freebsd_triage 2018-09-19 13:24:24 UTC 
Okay, I'll wait until tomorrow then.
If no new release, I'll commit your patch from PR.

Thanks.
Comment 7 David King 2018-09-20 12:31:09 UTC 
Created attachment 197273 [details]
update to 1.18.14
Comment 8 David King 2018-09-20 12:32:21 UTC 
add patch to 1.8.14

Thanks

Dave
Comment 9 David King 2018-09-20 12:40:51 UTC 
Created attachment 197274 [details]
upgrade to 1.8.14

Apologies, didn't set as patch before
Comment 10 commit-hook freebsd_committer freebsd_triage 2018-09-20 12:46:12 UTC 
A commit references this bug:

Author: demon
Date: Thu Sep 20 12:45:17 UTC 2018
New revision: 480168
URL: https://svnweb.freebsd.org/changeset/ports/480168

Log:
  Update to version 1.8.14.

  PR:		231475
  Submitted by:	David King <king.c.david@googlemail.com>

Changes:
  head/net/haproxy/Makefile
  head/net/haproxy/distinfo
  head/net/haproxy/files/patch-fix-outofbounds
Comment 11 Dmitry Sivachenko freebsd_committer freebsd_triage 2018-09-20 12:46:44 UTC 
Port updated, thanks!