Bug 231477 - devel/ocaml-opam update to 2.0.0 [maintainer no longer uses FreeBSD]
Summary: devel/ocaml-opam update to 2.0.0 [maintainer no longer uses FreeBSD]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-19 13:10 UTC by Hannes Mehnert
Modified: 2018-09-21 23:04 UTC (History)
3 users (show)

See Also:
joris: maintainer-feedback+

Attachments
tarball including Makefile, distinfo, pkg-descr, pkg-plist (1.18 KB, application/gzip)
2018-09-19 13:10 UTC, Hannes Mehnert 		no flags Details
diff -ur devel/ocaml-opam (3.76 KB, patch)
2018-09-19 17:05 UTC, Hannes Mehnert 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hannes Mehnert 2018-09-19 13:10:07 UTC 
Created attachment 197230 [details]
tarball including Makefile, distinfo, pkg-descr, pkg-plist

opam is the OCaml package manager.

opam 2.0.0 was released on 18th September, with opam 1.2.2 marked as deprecated (and there will be no more updates to the 1.2.2 opam repository).

I am not the maintainer, but he hasn't used FreeBSD for quite some time (please read https://github.com/ocaml/opam/pull/3444#issuecomment-406301072), and I am happy to take maintainership of ocaml-opam.

Attached is a tarball including the new port.  I followed the steps from https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html, did a portlint, and tested it locally with poudriere (on amd64, FreeBSD-CURRENT).

changes since 1.2.2:
- configure now checks for curl OR wget (-> curl is a BUILD_DEP now, no longer optional)
- camlp4 is no longer needed (removed runtime dependency)
- opam 2.0.0 uses gpatch (due to incompatibility in respect to diffs of binaries with BSD patch) -> dependency was added
Comment 1 Hannes Mehnert 2018-09-19 13:15:23 UTC 
oh, another change is that aspcud is no longer a runtime dependency since opam 2.0.0 ships with a custom cudf solver.
Comment 2 Hannes Mehnert 2018-09-19 17:05:56 UTC 
Created attachment 197236 [details]
diff -ur devel/ocaml-opam

additionally the files subdirectory needs to be removed (Only in ... in the patch).
Comment 3 Hannes Mehnert 2018-09-19 17:07:59 UTC 
(In reply to hannes from comment #0)
> - configure now checks for curl OR wget (-> curl is a BUILD_DEP now, no longer optional)

this is no longer true in the updated patch -- now --disable-checks is passed to configure, and curl is a runtime dependency instead.  fixed portlint warnings as well in the diff (you'll need to svn remove / rm the files subdirectory!)
Comment 4 Steve Wills freebsd_committer freebsd_triage 2018-09-21 21:55:36 UTC 
After applying the patch to the port, "make patch" no longer works. Should files/patch-configure go away?
Comment 5 Hannes Mehnert 2018-09-21 22:04:43 UTC 
(In reply to Steve Wills from comment #4)
yes, as mentioned in #2 the patch is no longer needed.
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-09-21 23:03:53 UTC 
A commit references this bug:

Author: swills
Date: Fri Sep 21 23:03:00 UTC 2018
New revision: 480326
URL: https://svnweb.freebsd.org/changeset/ports/480326

Log:
  devel/ocaml-opam: update to 2.0.0

  While here, pass maintainership to submitter

  PR:		231477
  PR:		231531
  Submitted by:	hannes@mehnert.org
  Approved by:	joris@giovannangeli.fr (maintainer)

Changes:
  head/devel/ocaml-opam/Makefile
  head/devel/ocaml-opam/distinfo
  head/devel/ocaml-opam/files/
  head/devel/ocaml-opam/pkg-plist
Comment 7 Steve Wills freebsd_committer freebsd_triage 2018-09-21 23:04:29 UTC 
Committed, thanks!